Skip to content

Conversation

@xiaoyatong
Copy link
Collaborator

@xiaoyatong xiaoyatong commented Jun 26, 2025

🤔 这个变动的性质是?

  • 新特性提交
  • 日常 bug 修复
  • 站点、文档改进
  • 演示代码改进
  • 组件样式/交互改进
  • TypeScript 定义更新
  • 包体积优化
  • 性能优化
  • 功能增强
  • 国际化改进
  • 重构
  • 代码风格优化
  • 测试用例
  • 分支合并
  • 其他改动(是关于什么的改动?)

🔗 相关 Issue

💡 需求背景和解决方案

☑️ 请求合并前的自查清单

⚠️ 请自检并全部勾选全部选项⚠️

  • 文档已补充或无须补充
  • 代码演示已提供或无须提供
  • TypeScript 定义已补充或无须补充
  • fork仓库代码是否为最新避免文件冲突
  • Files changed 没有 package.json lock 等无关文件

Summary by CodeRabbit

  • 样式

    • 表单项标签的默认字体大小由14px调整为12px,视觉上更为紧凑。
    • 字体大小现可通过变量灵活配置,提升自定义能力。
  • 文档

    • 更新了表单组件文档中的标签字体大小默认值说明,保持与实际样式一致。

@github-actions github-actions bot added action:review This PR needs more reviews (less than 2 approvals) 3.x Target branch 3.x labels Jun 26, 2025
@xiaoyatong xiaoyatong linked an issue Jun 26, 2025 that may be closed by this pull request
@coderabbitai
Copy link

coderabbitai bot commented Jun 26, 2025

## Walkthrough

本次更改将表单项标签的字体大小从固定值改为使用 Sass 变量,并将该变量的默认值由基础字号调整为更小的字号。这样字体大小可以通过变量灵活配置,而不是写死在样式中。

## Changes

| 文件/分组                           | 变更摘要                                               |
|-------------------------------------|--------------------------------------------------------|
| src/packages/formitem/formitem.scss | `.nut-form-item-labeltxt` 的字体大小由 `12px` 改为 `$form-item-label-font-size` 变量 |
| src/styles/variables.scss           | `$form-item-label-font-size` 默认值由 `$font-size-base` 改为 `$font-size-s`        |
| src/packages/form/doc*.md           | 文档中表单项标签字体大小 CSS 变量默认值由 `14px` 改为 `12px`                        |

## Possibly related issues

- jdf2e/nutui-react#3260:该 PR 将表单项标签字体大小从固定值改为可配置变量,直接解决了该 issue 中无法通过 ConfigProvider 修改字体大小的问题。

## Possibly related PRs

- jdf2e/nutui-react#2931:两者都修改了 `.nut-form-item-labeltxt` 样式,虽关注点不同,但都涉及该元素的样式调整。
- jdf2e/nutui-react#2872:两者都将 `.nut-form-item-labeltxt` 的字体大小由固定值改为变量 `$form-item-label-font-size`,代码层面高度相关。
- jdf2e/nutui-react#2927:两者均涉及表单项标签字体样式的调整,且修改了相关 CSS 规则,存在直接关联。

## Suggested reviewers

- oasis-cloud

## Poem

> 兔子挥笔改样式,  
> 字体大小不再死,  
> 变量灵动可配置,  
> 标签更显小巧致。  
> 代码如诗随风舞,  
> UI焕新乐无数!  
> 🐇✨

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 920ab45 and c9a959e.

📒 Files selected for processing (4)
  • src/packages/form/doc.en-US.md (1 hunks)
  • src/packages/form/doc.md (1 hunks)
  • src/packages/form/doc.taro.md (1 hunks)
  • src/packages/form/doc.zh-TW.md (1 hunks)
✅ Files skipped from review due to trivial changes (4)
  • src/packages/form/doc.md
  • src/packages/form/doc.en-US.md
  • src/packages/form/doc.zh-TW.md
  • src/packages/form/doc.taro.md
⏰ Context from checks skipped due to timeout of 90000ms (2)
  • GitHub Check: build
  • GitHub Check: test

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
src/packages/formitem/formitem.scss (1)

31-34: font-size 重复声明,可适度精简

.nut-form-item-labeltxt 与父选择器 .nut-form-item-label 已同样设置 font-size: $form-item-label-font-size;,且值一致。若无额外层级覆盖需求,可去掉其一以减小 CSS 体积、提高可读性。

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between f6f1e06 and 920ab45.

📒 Files selected for processing (2)
  • src/packages/formitem/formitem.scss (1 hunks)
  • src/styles/variables.scss (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (4)
  • GitHub Check: build
  • GitHub Check: test
  • GitHub Check: test
  • GitHub Check: lint
🔇 Additional comments (1)
src/styles/variables.scss (1)

2134-2137: 变量默认值改为 $font-size-s 👍

$form-item-label-font-size 的默认值从基础字号下调到 $font-size-s(12 px)后,标签字号保持可配置同时更加精细,与设计稿一致,改动无功能性风险。

@codecov
Copy link

codecov bot commented Jun 26, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.79%. Comparing base (f6f1e06) to head (c9a959e).
Report is 1 commits behind head on feat_v3.x.

Additional details and impacted files
@@            Coverage Diff             @@
##           feat_v3.x    #3280   +/-   ##
==========================================
  Coverage      87.79%   87.79%           
==========================================
  Files            290      290           
  Lines          19089    19089           
  Branches        2939     2939           
==========================================
  Hits           16760    16760           
  Misses          2324     2324           
  Partials           5        5           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@xiaoyatong xiaoyatong merged commit 5b7eb80 into jdf2e:feat_v3.x Jun 26, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3.x Target branch 3.x action:review This PR needs more reviews (less than 2 approvals) size/S

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Form.Item lable标签样式不生效

1 participant