-
Notifications
You must be signed in to change notification settings - Fork 285
fix: taro demo build failed #2749
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Caution Review failedThe pull request is closed. Walkthrough
Changes
Possibly related PRs
Suggested labels
Suggested reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## V3.0 #2749 +/- ##
=======================================
Coverage 83.99% 83.99%
=======================================
Files 221 221
Lines 17878 17878
Branches 2676 2676
=======================================
Hits 15016 15016
Misses 2857 2857
Partials 5 5 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
⛔ Files ignored due to path filters (1)
packages/nutui-taro-demo/yarn.lock
is excluded by!**/yarn.lock
,!**/*.lock
📒 Files selected for processing (1)
packages/nutui-taro-demo/package.json
(1 hunks)
🔇 Additional comments (1)
packages/nutui-taro-demo/package.json (1)
115-117
: 版本冲突解决方案已确认
通过在 resolutions 中指定 Taro 相关包的版本,可以有效解决依赖树中的版本冲突问题,这是修复构建失败的合理解决方案。
"@tarojs/api": "4.0.8-beta.0", | ||
"@tarojs/components": "4.0.8-beta.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codebase verification
建议降级到 Taro 4.0.7 稳定版本
目前发现:
- Taro 已有稳定版本 4.0.7 可用
- 项目中所有的 Taro 相关依赖都使用了 4.0.8-beta.0 版本
- beta 版本可能存在未知的稳定性问题
建议:
- 将所有 @tarojs/* 依赖统一降级到 4.0.7 稳定版本
- 如果必须使用 4.0.8-beta.0,请:
- 在升级前备份当前可用版本
- 进行完整的回归测试
- 密切关注 4.0.8 正式版的发布时间
🔗 Analysis chain
请评估使用 beta 版本的风险
在 resolutions 中强制使用 beta 版本(4.0.8-beta.0)可能会带来稳定性风险。建议:
- 确认是否必须使用 beta 版本
- 如果可能,考虑等待正式版本发布
- 在升级到正式版之前,请充分测试以确保稳定性
Let me check if there are any stable releases of Taro 4.x available.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# 检查是否有稳定版本可用
curl -s https://registry.npmjs.org/@tarojs/api | jq -r '.versions | keys[]' | grep -v "beta" | sort -V | tail -n 5
curl -s https://registry.npmjs.org/@tarojs/components | jq -r '.versions | keys[]' | grep -v "beta" | sort -V | tail -n 5
Length of output: 386
Script:
#!/bin/bash
# Check for stable releases of Taro 4.x
curl -s https://registry.npmjs.org/@tarojs/api | jq -r '.versions | keys[]' | grep '^4\.' | grep -v 'beta\|canary\|alpha' | sort -V | tail -n 5
curl -s https://registry.npmjs.org/@tarojs/components | jq -r '.versions | keys[]' | grep '^4\.' | grep -v 'beta\|canary\|alpha' | sort -V | tail -n 5
# Check package.json to understand if other Taro dependencies are also using beta versions
cat packages/nutui-taro-demo/package.json | grep "@tarojs/"
Length of output: 1457
🤔 这个变动的性质是?
🔗 相关 Issue
💡 需求背景和解决方案
☑️ 请求合并前的自查清单
Summary by CodeRabbit
新特性
@tarojs/api
和@tarojs/components
的指定版本4.0.8-beta.0
。修复
sass
的版本为1.77.6
,未做更改。删除
Popup
组件及其相关接口,取消了可定制的模态弹窗功能。