-
Notifications
You must be signed in to change notification settings - Fork 285
fix(uploader): correct xhrBeforeUpload execution timing #2507
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Walkthrough此次修改对 Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## next #2507 +/- ##
==========================================
+ Coverage 83.01% 83.04% +0.02%
==========================================
Files 217 217
Lines 17744 17746 +2
Branches 2546 2549 +3
==========================================
+ Hits 14731 14737 +6
+ Misses 3008 3004 -4
Partials 5 5 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
原来taroUpload的代码逻辑似乎有错误.
有beforeXhrUpload应该执行,而不是被env === 'WEB'所拦截了
Summary by CodeRabbit
beforeXhrUpload选项的支持,允许在上传前执行自定义逻辑。