Skip to content

fix(tabs): 修复tabs异步设置titles滚动失效（#2351） #2369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 21, 2024
Merged

fix(tabs): 修复tabs异步设置titles滚动失效（#2351） #2369

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
85528ba
fix(tabs): 修复tabs异步设置titles滚动失效（#2351）
ShuchenEason Jun 19, 2024
3809973
Merge branch 'next' into eason/fix/0619/tabs
ShuchenEason Jun 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/packages/tabs/tabs.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,10 +101,12 @@ export const Tabs: FunctionComponent<Partial<TabsProps>> & {
const scrollIntoView = (index: number, immediate?: boolean) => {
const nav = navRef.current
const titleItem = titleItemsRef.current
if (!nav || !titleItem || !titleItem[index]) {
const titlesLength = titles.current.length
const itemLength = titleItemsRef.current.length
if (!nav || !titleItem || !titleItem[itemLength - titlesLength + index]) {
return
}
const title = titleItem[index]
const title = titleItem[itemLength - titlesLength + index]

let to = 0
if (direction === 'vertical') {
Expand Down