jdb/2023 11 use github action

.github/ISSUE_TEMPLATE/feature_request.md

@@ -1,6 +1,6 @@
 ---
 name: Feature request
-about: Suggest an idea for Phlare.
+about: Suggest an idea for Pyroscope.
 title: ''
 labels: ''
 assignees: ''

.github/ISSUE_TEMPLATE/issue--bug-report.md

@@ -1,6 +1,6 @@
 ---
 name: Bug Report
-about: Create a report to help us improve Phlare.
+about: Create a report to help us improve Pyroscope.
 title: ''
 labels: ''
 assignees: ''
@@ -13,7 +13,7 @@ A clear and concise description of what the bug is.
 #### To Reproduce
 Steps to reproduce the behavior:
 
-1. Start Phlare (SHA or version)
+1. Start Pyroscope (SHA or version)
 2. Perform Operations(Read/Write/Others)
 
 #### Expected behavior

.github/workflows/e2e.yaml

@@ -3,7 +3,6 @@ on:
   push:
     branches:
       - main
-      - next
   pull_request:
 
 concurrency:
@@ -26,14 +25,14 @@ jobs:
       - name: Install Go
         uses: actions/setup-go@v4
         with:
-          go-version: "1.19.12"
-          cache: true         
+          go-version: "1.21.3"
+          cache: true
       - run: yarn --frozen-lockfile
       - run: make build
       - name: Cypress run
         uses: cypress-io/github-action@v5
         with:
-          wait-on: http://localhost:4100/ready
+          wait-on: http://localhost:4040/ready
           start: make run
           config-file: cypress/ci.ts
         env:
@@ -56,8 +55,8 @@ jobs:
       - name: Install Go
         uses: actions/setup-go@v4
         with:
-          go-version: "1.19.12"
-          cache: true         
+          go-version: "1.21.3"
+          cache: true
       - run: yarn --frozen-lockfile
       - run: make build
       - name: run nginx with /foobar/

.github/workflows/frontend.yml

@@ -3,7 +3,6 @@ on:
   push:
     branches:
       - main
-      - next
   pull_request:
 
 concurrency:

.github/workflows/helm-ci.yml

@@ -6,11 +6,12 @@ jobs:
   call-lint:
     uses: grafana/helm-charts/.github/workflows/linter.yml@main
     with:
-      filter_regex_include: .*operations/phlare/helm/.*
+      filter_regex_include: .*operations/pyroscope/helm/.*
 
   call-lint-test:
     uses: grafana/helm-charts/.github/workflows/lint-test.yaml@main
     with:
-      ct_configfile: operations/phlare/helm/ct.yaml
+      ct_configfile: operations/pyroscope/helm/ct.yaml
       ct_check_version_increment: false
       helm_version: v3.8.2
+      kubeVersion: "1.22"

.github/workflows/helm-release.yml

@@ -4,15 +4,14 @@ on:
   push:
     branches:
       - main
-      - next
       - "release-[0-9]+.[0-9]+"
 
 jobs:
   call-update-helm-repo:
     uses: grafana/helm-charts/.github/workflows/update-helm-repo.yaml@main
     with:
-      charts_dir: operations/phlare/helm/
-      cr_configfile: operations/phlare/helm/cr.yaml
-      ct_configfile: operations/phlare/helm/ct.yaml
+      charts_dir: operations/pyroscope/helm/
+      cr_configfile: operations/pyroscope/helm/cr.yaml
+      ct_configfile: operations/pyroscope/helm/ct.yaml
     secrets:
       helm_repo_token: ${{ secrets.GH_BOT_ACCESS_TOKEN }}

.github/workflows/publish-technical-documentation-next.yml

@@ -4,7 +4,6 @@ on:
   push:
     branches:
     - main
-    - next
     paths:
     - "docs/sources/**"
   workflow_dispatch:

.github/workflows/publish-technical-documentation-release.yml

@@ -24,7 +24,7 @@ jobs:
     needs: "test"
     steps:
 
-    - name: "Checkout Phlare repo"
+    - name: "Checkout Pyroscope repo"
       uses: "actions/checkout@v3"
       with:
         fetch-depth: 0

.github/workflows/release.yml

@@ -28,7 +28,7 @@ jobs:
       - run: git fetch --force --tags
       - uses: actions/setup-go@v3
         with:
-          go-version: "1.19.12"
+          go-version: "1.21.3"
           cache: true
       - uses: actions/setup-node@v3
         with:
@@ -59,7 +59,29 @@ jobs:
           version: latest
           args: release --rm-dist --timeout 60m
         env:
-          GITHUB_TOKEN: ${{ steps.app-releaser.outputs.token }}
+          GITHUB_TOKEN: ${{ steps.app-goreleaser.outputs.token }}
           # Your GoReleaser Pro key, if you are using the 'goreleaser-pro'
           # distribution:
           # GORELEASER_KEY: ${{ secrets.GORELEASER_KEY }}
+
+      # make generate-formulas expects PYROSCOPE_TAG to be set
+      - name: Set PYROSCOPE_TAG
+        run: echo "PYROSCOPE_TAG=${GITHUB_REF#refs/*/}" >> $GITHUB_ENV
+      - name: Get github app token (valid for an hour)
+        id: brew-token
+        uses: tibdex/github-app-token@v1
+        with:
+          app_id: ${{ secrets.APP_ID }}
+          private_key: ${{ secrets.APP_PRIVATE_KEY }}
+          repository: pyroscope-io/homebrew-brew
+      - name: Update homebrew formulas
+        run: |
+          git config --global url."https://x-access-token:$(echo "${HOMEBREW_GITHUB_TOKEN}" | xargs)@github.com/pyroscope-io/homebrew-brew".insteadOf "https://github.com/pyroscope-io/homebrew-brew"
+          git config --global user.email "[email protected]"
+          git config --global user.name "Pyroscope Bot <[email protected]>"
+          git clone https://github.com/pyroscope-io/homebrew-brew ../homebrew-brew
+          cd ../homebrew-brew
+          make generate-formulas && git add Formula && git commit -m "chore: update formulas" && git push origin main
+        env:
+          HOMEBREW_GITHUB_TOKEN: ${{ steps.brew-token.outputs.token }}
+          GITHUB_TOKEN: ${{ steps.app-goreleaser.outputs.token }}

.github/workflows/test.yml

@@ -3,7 +3,6 @@ on:
   push:
     branches:
       - main
-      - next
       - r[0-9]+ # Trigger builds after a push to weekly branches
   pull_request:
 
@@ -23,7 +22,7 @@ jobs:
       - name: Install Go
         uses: actions/setup-go@v4
         with:
-          go-version: 1.19.12
+          go-version: 1.21.3
       - name: Format
         run: make fmt check/unstaged-changes
   test:
@@ -34,7 +33,7 @@ jobs:
       - name: Install Go
         uses: actions/setup-go@v4
         with:
-          go-version: 1.19.12
+          go-version: 1.21.3
       - name: Go Mod
         run: make check/go/mod
       - name: Test
@@ -48,7 +47,7 @@ jobs:
       - name: Install Go
         uses: actions/setup-go@v4
         with:
-          go-version: 1.19.12
+          go-version: 1.21.3
       - name: Run linter
         run: make lint
       - name: Check helm manifests
@@ -61,8 +60,28 @@ jobs:
         uses: "actions/checkout@v3"
       - name: "Test docs"
         run: make docs/test
-      - name: "Validate docs"
-        run: make docs/validate
+
+  doc-validator:
+    runs-on: "ubuntu-latest"
+    container:
+      image: "grafana/doc-validator:v3.2.0"
+    steps:
+      - name: "Checkout code"
+        uses: "actions/checkout@v3"
+      - name: "Run doc-validator tool"
+        run: >
+          doc-validator
+          '--skip-checks=^image.+$'
+          docs/sources
+          /docs/writers-toolkit
+          | reviewdog
+          -f=rdjsonl
+          --fail-on-error
+          --filter-mode=nofilter
+          --name=doc-validator
+          --reporter=github-pr-review
+        env:
+          REVIEWDOG_GITHUB_API_TOKEN: "${{ secrets.GITHUB_TOKEN }}"
 
   build-image:
     if: github.event_name != 'push'
@@ -78,12 +97,12 @@ jobs:
       - name: Set up go
         uses: actions/setup-go@v2
         with:
-          go-version: 1.19.12
+          go-version: 1.21.3
       - uses: actions/setup-node@v3
         with:
           node-version: lts/hydrogen
           cache: yarn
-      - name: Build image Phlare
+      - name: Build image Pyroscope
         run: make docker-image/pyroscope/build "BUILDX_ARGS=--cache-from=type=gha --cache-to=type=gha"
 
   build-push:
@@ -100,7 +119,7 @@ jobs:
       - name: Set up go
         uses: actions/setup-go@v2
         with:
-          go-version: 1.19.12
+          go-version: 1.21.3
       - uses: actions/setup-node@v3
         with:
           node-version: lts/hydrogen
@@ -111,7 +130,7 @@ jobs:
           registry: us.gcr.io
           username: _json_key
           password: ${{ secrets.GCR_JSON_KEY }}
-      - name: Phlare Build & push multi-arch image
+      - name: Pyroscope Build & push multi-arch image
         id: build-push
         run: |
           make docker-image/pyroscope/push "BUILDX_ARGS=--cache-from=type=gha --cache-to=type=gha"

.github/workflows/update-make-docs.yml

@@ -0,0 +1,16 @@
+name: Update `make docs` procedure
+on:
+  schedule:
+    - cron: '0 7 * * 1-5'
+  workflow_dispatch:
+jobs:
+  main:
+    if: github.repository == 'grafana/pyroscope'
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v4
+      - uses: grafana/writers-toolkit/update-make-docs@update-make-docs/v1
+        with:
+          pr_options: >
+            --label type/docs
+          trace: true

.github/workflows/weekly-release.yml

@@ -25,7 +25,7 @@ jobs:
           git tag "$WEEKLY_IMAGE_TAG"
       - uses: actions/setup-go@v3
         with:
-          go-version: "1.19.12"
+          go-version: "1.21.3"
           cache: true
       # setup docker buildx
       - name: Set up QEMU

.gitmodules

@@ -0,0 +1,3 @@
+[submodule "ebpf/testdata"]
+	path = ebpf/testdata
+	url = https://github.com/pyroscope-io/pyroscope-ebpf-testdata.git

.golangci.yml

@@ -53,10 +53,11 @@ linters-settings:
     local-prefixes: github.com/grafana/pyroscope/pkg,github.com/grafana/pyroscope/api,github.com/grafana/pyroscope/tools
 
   depguard:
-    list-type: blacklist
-    include-go-root: true
-    packages-with-error-message:
-      - github.com/go-kit/kit/log: "Use github.com/go-kit/log instead of github.com/go-kit/kit/log"
+    rules:
+      main:
+        deny:
+          - pkg: "github.com/go-kit/kit/log"
+            desc: "Use github.com/go-kit/log instead of github.com/go-kit/kit/log"
 
   revive:
     rules:

.goreleaser.yaml

@@ -1,8 +1,8 @@
 project_name: pyroscope
 before:
   hooks:
-    # This hook ensures that goreleaser uses the correct go version for a Phlare release
-    - sh -euc "go version | grep "go version go1.19.12 " || { echo "Unexpected go version"; exit 1; }"
+    # This hook ensures that goreleaser uses the correct go version for a Pyroscope release
+    - sh -euc "go version | grep "go version go1.21.3 " || { echo "Unexpected go version"; exit 1; }"
 builds:
   - env:
       - CGO_ENABLED=0
@@ -142,6 +142,25 @@ docker_manifests:
       - grafana/{{ .ProjectName }}:latest-arm64v8
       - grafana/{{ .ProjectName }}:latest-armv6
       - grafana/{{ .ProjectName }}:latest-armv7
+nfpms:
+  - id: pyroscope
+    formats:
+      - deb
+      - rpm
+    section: default
+    maintainer: Grafana Labs <[email protected]>
+    vendor: Grafana Labs Inc
+    homepage: https://grafana.com/pyroscope
+    license: AGPL-3.0
+    contents:
+      - src: ./tools/packaging/pyroscope.service
+        dst: /etc/systemd/system/pyroscope.service
+      - src: ./cmd/pyroscope/pyroscope.yaml
+        dst: /etc/pyroscope/config.yml
+        type: config|noreplace
+    scripts:
+      postinstall: ./tools/packaging/postinstall.sh
+
 archives:
   - id: pyroscope
     builds:

.husky/pre-commit

@@ -0,0 +1,4 @@
+#!/usr/bin/env sh
+. "$(dirname -- "$0")/_/husky.sh"
+
+npx lint-staged

CODEOWNERS

@@ -2,7 +2,13 @@
 * @grafana/pyroscope-team
 
 # Documentation.
-/docs/ @grafana/docs-profiles @grafana/pyroscope-team
+/.github/workflows/publish-technical-documentation-next.yml     @jdbaldry
+/.github/workflows/publish-technical-documentation-release.yml  @jdbaldry
+/.github/workflows/update-make-docs.yml                         @jdbaldry
+/docs/                                                          @grafana/docs-profiles @grafana/pyroscope-team
+/docs/docs.mk                                                   @jdbaldry
+/docs/make-docs                                                 @jdbaldry
+/docs/variables.mk                                              @jdbaldry
 
 # eBPF collector
 /ebpf/ @korniltsev