Allow APNS tokens of variable length. #678
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ianlater
force-pushed
the
fix-apns-token-validation
branch
from
7a55408 to
9c5fbbc
Compare
|
|
||
| if hex_re.match(value) is None or len(value) not in (64, 200): | ||
| # https://developer.apple.com/documentation/uikit/uiapplicationdelegate/1622958-application | ||
| # As of 02/2023 APNS tokens (registration_id) "are of variable length. Do not hard-code their size." |
There was a problem hiding this comment.
Suggested change
| # As of 02/2023 APNS tokens (registration_id) "are of variable length. Do not hard-code their size." | |
| # As of 02/2023, APNs device tokens (registration_id) are of variable length. Do not hard-code their size. |
jamaalscarlett
approved these changes
Aug 19, 2023
blighj
pushed a commit
to blighj/django-push-notifications
that referenced
this pull request
Sep 30, 2023
Co-authored-by: Ian Later <[email protected]>
50-Course
pushed a commit
that referenced
this pull request
Oct 3, 2024
Co-authored-by: Ian Later <[email protected]>
50-Course
pushed a commit
that referenced
this pull request
Oct 6, 2024
Co-authored-by: Ian Later <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hopefully solves #537