Implement missing, and/or unlinked native methods in Unsafe #105
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rename JPF_sun_misc_Unsafe.java to JPF_jdk_internal_misc_Unsafe This implements the missing methods in Unsafe model class to prevent: [junit] java.lang.NoSuchMethodError: jdk.internal.misc.Unsafe.objectFieldOffset(Ljava/lang/Class;Ljava/lang/String;)J And implement respective NativePeer methods in JPF_jdk_internal_misc_Unsafe, to prevent: [junit] java.lang.UnsatisfiedLinkError: cannot find native jdk.internal.misc.Unsafe.objectFieldOffset
This exports java.base/jdk.internal.misc to the UNNAMED module (in ant
target --compile-tests), so to be able to reference
gov.nasa.jpf.test.java.misc.UnsafeTest within UnsafeTest
So to prevent:
[javac] src/tests/gov/nasa/jpf/test/java/misc/UnsafeTest.java:4: error: package jdk.internal.misc is not visible
[javac] import jdk.internal.misc.Unsafe;
[javac] ^
[javac] (package jdk.internal.misc is declared in module java.base, which does not export it to the unnamed module)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements the missing methods in Unsafe model class to prevent NoSuchMethodError(s), and their respective NativePeer methods in JPF_jdk_internal_misc_Unsafe to prevent UnsatisfiedLinkError(s).
Fixes: #99