warning: ChoiceGeneratorBase() in ChoiceGeneratorBase has been deprecated

[gayanW]

Compiler warning "[deprecation] ChoiceGeneratorBase() in ChoiceGeneratorBase has been deprecated" when build with JDK 9 and later.

[javac] /home/travis/build/javapathfinder/jpf-core/src/main/gov/nasa/jpf/vm/choice/PermutationCG.java:35: warning: [deprecation] ChoiceGeneratorBase() in ChoiceGeneratorBase has been deprecated
[javac]   public PermutationCG (PermutationGenerator pg){
[javac]                                                 ^

jpf-core/src/main/gov/nasa/jpf/vm/choice/PermutationCG.java

Lines 30 to 43 in 18a0c42

	public class PermutationCG extends ChoiceGeneratorBase<int[]>{
	protected PermutationGenerator pg;
	protected int[] permutation;
	public PermutationCG (PermutationGenerator pg){
	this.pg = pg;
	}
	public PermutationCG (String id, PermutationGenerator pg){
	super(id);
	this.pg = pg;
	}

Default constructor of the super class 'gov.nasa.jpf.vm.ChoiceGeneratorBase' is marked deprecated, but the constructor PermutationCG (PermutationGenerator) is not, thus resulting in the warning.

jpf-core/src/main/gov/nasa/jpf/vm/ChoiceGeneratorBase.java

Lines 99 to 110 in 18a0c42

	/**
	* don't use this since it is not safe for cascaded ChoiceGenerators
	* (we need the 'id' to be as context specific as possible)
	*/
	@Deprecated
	protected ChoiceGeneratorBase() {
	id = "?";
	}
	protected ChoiceGeneratorBase(String id) {
	this.id = id;
	}

Travis log:
https://travis-ci.org/javapathfinder/jpf-core/builds/385707808#L2425-L2427

[cyrille-artho]

Actually, neither of the default constructors is used by jpf-core itself (internally).
However, some of the other projects may use it.
I would consider removing the default constructor, but we should give extension writers time to adapt.
Therefore, I'd mark both constructors (PermutationCG and ChoiceGeneratorBase) with
@Deprecated(forRemoval=true)
and would also insert an annotation that suppresses this warning in the constructor of PermutationCG.