Add __delitem__ #224
Merged
Add __delitem__ #224
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmerry
requested changes
Nov 8, 2018
fakeredis.py
Outdated
| continue | ||
| return deleted | ||
|
|
||
| @_locked |
There was a problem hiding this comment.
self.delete already takes the lock, so it's unnecessary for this function to be locked.
|
Force pushed a commit without the unnecessary @_locked decorator. |
bmerry
approved these changes
Nov 8, 2018
|
Thanks, merged! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #223
A separate travis-ci run that shows the test first failing without implementation:
https://travis-ci.org/viljoviitanen/fakeredis/builds/452512706
Also to make things sure: I allow my small contribution to be distributed under any licence and assign copyright to current copyright owners.