Skip to content

Conversation

@smblott-github
Copy link

I was working on integrating your work into another project, and this was pretty much the only change I had to make to the body of your code. It allows the handling of ESCAPE to be shared between the two components.

Any chance you might merge it?

@smblott-github
Copy link
Author

I should say the only other change I made to your code was to wrap the whole lot inside a function (to keep the namespace clean) and export only the VIM object/class.

If you did the same here, then I could pretty much drop your code directly into the other project (philc/vimium#1186), and point anybody who wanted to improve your insert-mode vim back here, then pull those improvements upstream.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant