Skip to content

Golang version upgrade #57

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 18, 2024
Merged

Golang version upgrade #57

merged 1 commit into from
May 18, 2024

Conversation

@camcast3
Copy link
Contributor

@camcast3 camcast3 commented May 17, 2024 •
edited
Loading

Fixing golang security vulns for stdlib v1.20.10 by upgrading to v1.21.10

Detected by docker scout
image

@camcast3
Copy link
Contributor Author

camcast3 commented May 17, 2024

Workflow test passed in my fork: https://github.com/camcast3/rcon-cli/actions/runs/9134257961/job/25119434978?pr=1

itzg
itzg reviewed May 18, 2024
View reviewed changes
Copy link
Owner

@itzg itzg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I'm happy to merge this but curious the particular choice of upgraded version.

.github/workflows/release.yml
uses: itzg/github-workflows/.github/workflows/go-with-releaser-image.yml@main
with:
go-version: "1.20.10"
go-version: "1.21.10"
Copy link
Owner

@itzg itzg May 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was fixed in 1.20.11. Why bump the entire minor version?

Copy link
Contributor Author

@camcast3 camcast3 May 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The first two in the list will be fixed by Golang v1.20.11.

However next 7 will be a longer term patch using +v1.21.9 so I used the latest stable in that minor version set
image

https://scout.docker.com/vulnerabilities/id/CVE-2024-24785/org/camcast3?s=golang&n=stdlib&t=golang&vr=%3C1.21.8&utm_source=desktop&utm_medium=ExternalLink

Copy link
Contributor Author

@camcast3 camcast3 May 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can move to 1.20.14 if you are more comfortable with that

Copy link
Owner

@itzg itzg May 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That all sounds good. I was focused on the major CVE item.

@itzg itzg merged commit d308e80 into itzg:master May 18, 2024
@camcast3 camcast3 deleted the camcast3/vuln_fix branch May 18, 2024 18:32
@itzg itzg mentioned this pull request May 18, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@itzg itzg itzg left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@camcast3 @itzg