Skip to content

paper: fall back to VERSION env var when jar missing metadata #422

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 27, 2024
Merged

paper: fall back to VERSION env var when jar missing metadata #422

merged 1 commit into from
Apr 27, 2024

Conversation

@itzg
Copy link
Owner

@itzg itzg commented Apr 27, 2024

Follow up to #420 since downstream processing needs a valid version

@itzg itzg added the enhancement New feature or request label Apr 27, 2024
@itzg itzg merged commit 1898ff8 into master Apr 27, 2024
@itzg itzg deleted the fix/paper-custom-fallback-version-env branch April 27, 2024 21:19
@itzg itzg mentioned this pull request Apr 27, 2024
Merged
itzg added a commit that referenced this pull request Apr 28, 2024
@itzg
Revert "paper: fall back to VERSION env var when jar missing metadata (…
0686a27 
…#422)"

This reverts commit 1898ff8.
@itzg itzg mentioned this pull request Apr 28, 2024
Merged
itzg added a commit that referenced this pull request Apr 28, 2024
@itzg
paper: restore requirement of version.json metadata (#423)
677ac63 
* Revert "paper: fall back to VERSION env var when jar missing metadata (#422)"

This reverts commit 1898ff8.

* Revert "paper: version metadata is optional for custom server jar (#420)"

This reverts commit d55e8f8.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@itzg