Skip to content

Correctly read binaryStreamOnly param #728

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 19, 2019
Merged

Correctly read binaryStreamOnly param #728

merged 2 commits into from
Oct 19, 2019

Conversation

@ball-hayden
Copy link
Contributor

@ball-hayden ball-hayden commented Aug 5, 2019 •
edited
Loading

Fixes #727

options[@"binaryStreamOnly"] isn't a BOOL, but is actually a _NSCFBoolean.
To correctly read the value of it, we must get the boolValue of the object.

@itinance itinance merged commit e6d35b3 into itinance:master Oct 19, 2019
@itinance
Copy link
Owner

itinance commented Oct 19, 2019

Many thanks!

@itinance itinance mentioned this pull request Oct 19, 2019
Closed
@snyk-bot snyk-bot mentioned this pull request Feb 29, 2020
Merged
@snyk-bot snyk-bot mentioned this pull request Apr 19, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

iOS uploads stuck in binaryStreamOnly mode

2 participants

@ball-hayden @itinance