Skip to content

move to golangci unused #672

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 22, 2022
Merged

move to golangci unused #672

merged 1 commit into from
Sep 22, 2022

Conversation

zirain
Copy link
Member

@zirain zirain commented Sep 22, 2022 •
edited
Loading

@zirain zirain requested a review from a team as a code owner September 22, 2022 09:28
@istio-testing istio-testing added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 22, 2022
This was referenced Sep 22, 2022
Closed
Merged
@ericvn
Copy link
Contributor

ericvn commented Sep 22, 2022

Thanks for doing this.

@ericvn ericvn added the do-not-merge Block automatic merging of a PR. label Sep 22, 2022
@ericvn
Copy link
Contributor

ericvn commented Sep 22, 2022

Label DNM until istio/istio#41112 is merged.

@ericvn ericvn removed the do-not-merge Block automatic merging of a PR. label Sep 22, 2022
@ericvn
Copy link
Contributor

ericvn commented Sep 22, 2022

Let this merge.

@istio-testing istio-testing merged commit 2eb9688 into istio:master Sep 22, 2022
@zirain zirain deleted the lint-unused branch September 23, 2022 00:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@howardjohn howardjohn howardjohn approved these changes

Assignees
No one assigned
Labels
size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zirain @ericvn @howardjohn @istio-testing