Clarify Service Entry addresses behavior limitations #3549
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Faseela K <[email protected]>
|
😊 Welcome @kfaseela! This is either your first contribution to the Istio api repo, or it's been You can learn more about the Istio working groups, Code of Conduct, and contribution guidelines Thanks for contributing! Courtesy of your friendly welcome wagon. |
istio-testing
added
the
size/XS
kfaseela
added
the
release-notes-none
|
/retest |
ilrudie
reviewed
Aug 14, 2025
Comment on lines
+485
to
+487
| // addresses are not supported in this field. Note that the `addresses` | ||
| // API implies you can provide multiple addresses but there are limitations | ||
| // on it (e.g.: you cannot set VIP addresses regardless of the combination of ip families). |
There was a problem hiding this comment.
I have a hard time understanding what this means. I think the clarification we wish to convey is that multiple VIPs will not be assigned to a single host, even though having a list suggests that might occur. As a result of this, you are not able to specify dual-stack VIPs using this field.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: istio/istio#34577