Skip to content

[CI] js: test: Decouple screenshots from regular e2e tests #890

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 28, 2022

Conversation

ix5
Copy link
Member

@ix5 ix5 commented May 28, 2022

Checklist

  • All new and existing tests are passing
  • (If adding features:) I have added tests to cover my changes
  • (If docs changes needed:) I have updated the documentation accordingly.
  • I have added an entry to CHANGES.rst because this is a user-facing change or an important bugfix
  • I have written proper commit message(s)

What changes does this Pull Request introduce?

Decouple the screenshot tests from integration test suite.

Why is this necessary?

Screenshot tests are a bit confusing for beginners.

@ix5 ix5 added testing/ci Test coverage & GitHub actions etc. improvement Not a new feature, but makes Isso more pleasant to use labels May 28, 2022
@ix5 ix5 added this to the 0.13 milestone May 28, 2022
@ix5
Copy link
Member Author

ix5 commented May 28, 2022

Python tests are currently broken due to pallets-eco/flask-caching#352
If the flask-caching maintainers don't fix this issue in time, we'll need to add cachelib to our own deps or pin an older version of flask-caching.

@ix5 ix5 merged commit 360bc6c into isso-comments:master May 28, 2022
@ix5 ix5 deleted the ci-screenshots branch May 28, 2022 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Not a new feature, but makes Isso more pleasant to use testing/ci Test coverage & GitHub actions etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant