Skip to content

admin: restore comment content after cancel edit #470

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

rocka
Copy link
Contributor

@rocka rocka commented Jul 30, 2018

save comment innerHTML under elt.dataset['originContent'], and restore it if edit action was canceled.

output

ix5 pushed a commit to ix5/isso that referenced this pull request Jan 15, 2021
Cherry-picked from isso-comments/pull/470/commits/395e8765f10584963d4e394bf556e286de325733
Adapted to new location inside admin.js.
@ix5
Copy link
Member

ix5 commented Jan 15, 2021

This is a valid PR. I've pushed to https://github.com/ix5/isso/tree/abort-edit-save to use the new location of admin.js instead of inline js inside the template. Feel free to force-push.

ix5 pushed a commit to ix5/isso that referenced this pull request Jan 15, 2021
Cherry-picked from isso-comments/pull/470/commits/395e8765f10584963d4e394bf556e286de325733
Adapted to new location inside admin.js.
ix5 pushed a commit to ix5/isso that referenced this pull request Feb 4, 2021
Cherry-picked from isso-comments/pull/470/commits/395e8765f10584963d4e394bf556e286de325733
Adapted to new location inside admin.js.
@ix5 ix5 mentioned this pull request Dec 22, 2021
Copy link
Member

@jelmer jelmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please resolve the conflicts?

@rocka rocka force-pushed the feature/admin-restore-after-cancel-edit branch from 395e876 to 2391e8e Compare December 23, 2021 09:52
@rocka
Copy link
Contributor Author

rocka commented Dec 23, 2021

I've rebased the commit againt master branch (5f3bf4f as now), and confirmed it works on my local deployment. Could you please review it?

@blatinier blatinier merged commit fb6f731 into isso-comments:master Dec 23, 2021
@blatinier
Copy link
Collaborator

Thanks for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants