Skip to content

Conversation

@jacbn
Copy link
Contributor

@jacbn jacbn commented Oct 23, 2025

Adds the option to generate a QR code from the "Invite users" modal on the groups page.

The QR library is decently large (~90kb network) so, as in the MFA page, we lazily load this when the request to generate the code is made. This means the modal takes no longer to load than before, and the QR code does not take up too much space in the modal if it has not been requested.

@codecov
Copy link

codecov bot commented Oct 23, 2025

Codecov Report

❌ Patch coverage is 10.52632% with 34 lines in your changes missing coverage. Please review.
✅ Project coverage is 41.61%. Comparing base (13187ee) to head (9bb501e).
⚠️ Report is 51 commits behind head on main.

Files with missing lines Patch % Lines
...rc/app/components/elements/panels/GroupQRPanel.tsx 0.00% 30 Missing ⚠️
...components/elements/modals/GroupsModalCreators.tsx 50.00% 3 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1795      +/-   ##
==========================================
- Coverage   41.65%   41.61%   -0.05%     
==========================================
  Files         541      542       +1     
  Lines       23685    23726      +41     
  Branches     7835     6995     -840     
==========================================
+ Hits         9867     9873       +6     
- Misses      13178    13811     +633     
+ Partials      640       42     -598     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jsharkey13 jsharkey13 merged commit 1be0573 into main Oct 29, 2025
10 checks passed
@jsharkey13 jsharkey13 deleted the improvement/group-code-qrs branch October 29, 2025 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants