Skip to content

Conversation

@mwtrew
Copy link
Contributor

@mwtrew mwtrew commented Oct 21, 2025

Moves PasswordResetHandler's endpoints to the users slice, which allows us to use that for error handling instead of generalErrors.

@mwtrew mwtrew changed the title Migrate password reset endpoints to RTK Query Migrate general errors to RTK Query Oct 21, 2025
actions-user and others added 4 commits October 21, 2025 16:12
…-rtk

[VRT] Update baselines for move-general-errors-to-rtk
This means I can switch endpoints over to RTKQ incrementally.
…isaac-react-app into move-general-errors-to-rtk
@codecov
Copy link

codecov bot commented Oct 22, 2025

Codecov Report

❌ Patch coverage is 92.30769% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 41.59%. Comparing base (13187ee) to head (e5f97fb).
⚠️ Report is 31 commits behind head on main.

Files with missing lines Patch % Lines
...c/app/components/handlers/PasswordResetHandler.tsx 90.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1793      +/-   ##
==========================================
- Coverage   41.65%   41.59%   -0.07%     
==========================================
  Files         541      541              
  Lines       23685    23682       -3     
  Branches     7835     6991     -844     
==========================================
- Hits         9867     9851      -16     
- Misses      13178    13789     +611     
+ Partials      640       42     -598     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mwtrew mwtrew marked this pull request as ready for review October 22, 2025 09:24
@mwtrew mwtrew changed the title Migrate general errors to RTK Query Migrate PasswordResetHandler endpoints to RTK Query Oct 22, 2025
@jacbn
Copy link
Contributor

jacbn commented Oct 24, 2025

I have pushed a change to remove the now-unused action types, but otherwise this looks good. I was having some issues not being able to reset a password through the standard means while testing, but that was an unrelated issue we semi-patched here, but could use some more thought on a deeper fix eventually. Made a card!

@mwtrew mwtrew merged commit ae06b3f into main Oct 24, 2025
10 checks passed
@mwtrew mwtrew deleted the move-general-errors-to-rtk branch October 24, 2025 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants