Re-enable required account info modal on Ada CS #1789
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-enables required account info modal on Ada CS and centralises logic for which fields are required in
validateFields, meaning the same logic is used for deciding which fields to show and checking the validity of the user object on submission. This creates a single source of truth for which fields are required across both sites, which will hopefully prevent validation and presentation logic from drifting apart in the future.validateFieldscould also be used to simplify validation in signup and My Account, but I haven't included that in this PR. I will create a card for that.Also replaces the old "big red text"-style error in the RAI modal with an
ExigentAlerton both sites, which looks nicer.