Skip to content

Conversation

@jacbn
Copy link
Contributor

@jacbn jacbn commented Oct 17, 2025

Does not apply to /events, as this ought to be a place to find all events. Does still adjust how getEventsList is called inside the Events component to be consistent.

jacbn added 2 commits October 17, 2025 16:56
Does not apply to `/events`, as this ought to be a place to find all events. Does still adjust how `getEventsList` is called inside the Events component to be consistent.
@codecov
Copy link

codecov bot commented Oct 17, 2025

Codecov Report

❌ Patch coverage is 40.00000% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 41.57%. Comparing base (e774a25) to head (df404f4).
⚠️ Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
src/app/components/pages/SubjectLandingPage.tsx 50.00% 3 Missing ⚠️
src/app/components/site/phy/HomepagePhy.tsx 33.33% 2 Missing ⚠️
src/app/components/pages/Events.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1784      +/-   ##
==========================================
- Coverage   41.57%   41.57%   -0.01%     
==========================================
  Files         535      535              
  Lines       23518    23521       +3     
  Branches     6938     7803     +865     
==========================================
  Hits         9778     9778              
+ Misses      13699    13106     -593     
- Partials       41      637     +596     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@sjd210 sjd210 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable 👍. Perhaps if this leads to confusion we may want to pre-apply the "Student events" filter on /events too but I'm happier leaving that for now.

@sjd210 sjd210 merged commit afec320 into main Oct 20, 2025
10 checks passed
@sjd210 sjd210 deleted the hotfix/hide-teacher-events-from-students branch October 20, 2025 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants