Skip to content

Conversation

@jacbn
Copy link
Contributor

@jacbn jacbn commented Oct 17, 2025

Adds a new Programmes section to the site, with listings for STEM SMART, SPC, PMS, and the biology challenges.

Currently these programme objects are 'fake' API objects of type 'IsaacProgrammeDTO'. This DTO does not (yet?) exist in the backend, but if we decide that programmes are better off being managed by content – something I believe to be quite likely – it will not require any additional frontend work as this setup is already built for that.

This also makes some slight modifications to Event and News cards on Isaac, which now have a white background, a more legible shadow, and much simplified text to improve appearance. The long layout is also now exclusively preferred for news, to be a little more consistent.

The biggest question that still has no satisfying solution is what to call the new navbar tab, since "Events" and "Programmes" are different things, and "Events and Programmes" is far too long. So far, I have simply kept the tab called "Events" with a subcategory also called "Events" underneath. More than happy to change if we come up with an appropriate alternative.

@codecov
Copy link

codecov bot commented Oct 17, 2025

Codecov Report

❌ Patch coverage is 27.18447% with 75 lines in your changes missing coverage. Please review.
✅ Project coverage is 41.52%. Comparing base (afec320) to head (3c11b79).
⚠️ Report is 45 commits behind head on main.

Files with missing lines Patch % Lines
src/app/components/elements/cards/EventCard.tsx 15.38% 22 Missing ⚠️
src/app/components/pages/Programmes.tsx 34.78% 15 Missing ⚠️
...rc/app/components/elements/cards/ProgrammeCard.tsx 47.36% 10 Missing ⚠️
src/test/pages/Programmes.cy.tsx 0.00% 9 Missing ⚠️
...c/app/components/elements/layout/SidebarLayout.tsx 11.11% 8 Missing ⚠️
src/app/services/events.tsx 33.33% 4 Missing ⚠️
src/app/components/elements/cards/NewsCard.tsx 25.00% 3 Missing ⚠️
src/app/components/pages/SubjectLandingPage.tsx 0.00% 2 Missing ⚠️
src/app/components/pages/Events.tsx 0.00% 1 Missing ⚠️
src/app/components/pages/News.tsx 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1781      +/-   ##
==========================================
- Coverage   41.57%   41.52%   -0.05%     
==========================================
  Files         535      538       +3     
  Lines       23521    23603      +82     
  Branches     6940     7812     +872     
==========================================
+ Hits         9778     9801      +23     
- Misses      13702    13761      +59     
  Partials       41       41              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@barna-isaac
Copy link
Contributor

barna-isaac commented Oct 20, 2025

The new Programmes page looks really nice, and I like the visual separation that the pods introduce to the Events and News pages.

I don't have comments regarding the code changes themselves, but have a few design notes.

  • I think using StyledTabpicker on the "Programmes" sidebar is a little confusing. This component usually affects the page, rather than perform navigation to a different page. When I started clicking through these, I was expecting the content to scroll into view.
  • I agree that Events -> Events feels unfinished. Maybe something like Get Involved -> Events (Meet Us -> Events)? We could also just have Events and Programmes both in the top level menu.
  • I wonder why we use Physics purple as the default / fallback on the Events page, but neutral black / green on the Programmes page?

@jacbn
Copy link
Contributor Author

jacbn commented Oct 20, 2025

I think using StyledTabpicker on the "Programmes" sidebar is a little confusing. This component usually affects the page, rather than perform navigation to a different page. When I started clicking through these, I was expecting the content to scroll into view.

This is what we do for books, but I agree it's not consistent with the main use case for it. I do like the idea of it scrolling to the relevant section though! Not to flaunt, but I think these cards are cleaner and more legible than the pages they link to so perhaps this makes it easier for users anyway. I've made the change.

I agree that Events -> Events feels unfinished. Maybe something like Get Involved -> Events (Meet Us -> Events)? We could also just have Events and Programmes both in the top level menu.

We can't make the top menu any bigger, as it overflows. Putting in the downwards caret next to Events already needed a small change to squeeze the menu a couple of pixels shy of the limit. I think content are best suited to come up with a name here, but I'll pass on the suggestions.

I wonder why we use Physics purple as the default / fallback on the Events page, but neutral black / green on the Programmes page?

Do you mean for the event cards? They are purple because they are tagged with a subject! The programmes ones aren't; I suppose we could do SPC and PMS purple, and bio green; but we can't pick one for STEM SMART and so the inconsistency of colours would be more noticeable than it ought to be.

@barna-isaac
Copy link
Contributor

thanks for the changes, @jacbn! Merging now.

@barna-isaac barna-isaac merged commit 3884800 into main Oct 21, 2025
10 checks passed
@barna-isaac barna-isaac deleted the feature/programmes-and-events branch October 21, 2025 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants