-
Notifications
You must be signed in to change notification settings - Fork 6
Isaac Programmes #1781
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Isaac Programmes #1781
Conversation
…-events [VRT] Update baselines for feature/programmes-and-events
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #1781 +/- ##
==========================================
- Coverage 41.57% 41.52% -0.05%
==========================================
Files 535 538 +3
Lines 23521 23603 +82
Branches 6940 7812 +872
==========================================
+ Hits 9778 9801 +23
- Misses 13702 13761 +59
Partials 41 41 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
The new I don't have comments regarding the code changes themselves, but have a few design notes.
|
This is what we do for books, but I agree it's not consistent with the main use case for it. I do like the idea of it scrolling to the relevant section though! Not to flaunt, but I think these cards are cleaner and more legible than the pages they link to so perhaps this makes it easier for users anyway. I've made the change.
We can't make the top menu any bigger, as it overflows. Putting in the downwards caret next to Events already needed a small change to squeeze the menu a couple of pixels shy of the limit. I think content are best suited to come up with a name here, but I'll pass on the suggestions.
Do you mean for the event cards? They are purple because they are tagged with a subject! The programmes ones aren't; I suppose we could do SPC and PMS purple, and bio green; but we can't pick one for STEM SMART and so the inconsistency of colours would be more noticeable than it ought to be. |
|
thanks for the changes, @jacbn! Merging now. |
Adds a new Programmes section to the site, with listings for STEM SMART, SPC, PMS, and the biology challenges.
Currently these programme objects are 'fake' API objects of type 'IsaacProgrammeDTO'. This DTO does not (yet?) exist in the backend, but if we decide that programmes are better off being managed by content – something I believe to be quite likely – it will not require any additional frontend work as this setup is already built for that.
This also makes some slight modifications to Event and News cards on Isaac, which now have a white background, a more legible shadow, and much simplified text to improve appearance. The long layout is also now exclusively preferred for news, to be a little more consistent.
The biggest question that still has no satisfying solution is what to call the new navbar tab, since "Events" and "Programmes" are different things, and "Events and Programmes" is far too long. So far, I have simply kept the tab called "Events" with a subcategory also called "Events" underneath. More than happy to change if we come up with an appropriate alternative.