Adds test fixture to run RL training over subset of envs #1912
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
jtigue-bdai
approved these changes
Feb 28, 2025
jtigue-bdai
reviewed
Feb 28, 2025
Collaborator
jtigue-bdai
left a comment
jtigue-bdai
left a comment
There was a problem hiding this comment.
Looks like a pre-commit formatting is needed though
hhansen-bdai
approved these changes
Feb 28, 2025
jsmith-bdai
reviewed
Feb 28, 2025
Collaborator
|
This is awesome! We will likely re-use this for our internal environments Can you update the description to include the refactoring of settings as well? I don't think any CI updates need to be made as we have the |
Mayankm96
commented
Mar 1, 2025
Signed-off-by: Mayank Mittal <[email protected]>
jtigue-bdai
pushed a commit
that referenced
this pull request
Apr 14, 2025
# Description This MR adds a script to run training over a subset of environments. I have mostly checked this for rsl-rl library. The script adds the commit tag as a run name allowing us to compare different versions of code nicely. ## Type of change - New feature (non-breaking change which adds functionality) ## Screenshots Example tensorboard log: ```bash ./isaaclab.sh -p tools/run_train_envs.py --lib-name rsl_rl ```  ## Checklist - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with `./isaaclab.sh --format` - [ ] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [x] I have added tests that prove my fix is effective or that my feature works - [ ] I have updated the changelog and the corresponding version in the extension's `config/extension.toml` file - [x] I have added my name to the `CONTRIBUTORS.md` or my name already exists there --------- Signed-off-by: Mayank Mittal <[email protected]>
ToxicNS
pushed a commit
to ToxicNS/IsaacLab
that referenced
this pull request
Apr 24, 2025
) # Description This MR adds a script to run training over a subset of environments. I have mostly checked this for rsl-rl library. The script adds the commit tag as a run name allowing us to compare different versions of code nicely. ## Type of change - New feature (non-breaking change which adds functionality) ## Screenshots Example tensorboard log: ```bash ./isaaclab.sh -p tools/run_train_envs.py --lib-name rsl_rl ```  ## Checklist - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with `./isaaclab.sh --format` - [ ] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [x] I have added tests that prove my fix is effective or that my feature works - [ ] I have updated the changelog and the corresponding version in the extension's `config/extension.toml` file - [x] I have added my name to the `CONTRIBUTORS.md` or my name already exists there --------- Signed-off-by: Mayank Mittal <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This MR adds a script to run training over a subset of environments. I have mostly checked this for rsl-rl library.
The script adds the commit tag as a run name allowing us to compare different versions of code nicely.
Type of change
Screenshots
Example tensorboard log:
Checklist
pre-commitchecks with./isaaclab.sh --formatconfig/extension.tomlfileCONTRIBUTORS.mdor my name already exists there