Removes duplicated TerminationsCfg code in G1 and H1 RoughEnvCfg
#1484
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fan-ziqi
requested review from
Dhoeller19,
Mayankm96,
jsmith-bdai and
jtigue-bdai
as code owners
kellyguo11
changed the title
TerminationsCfg codeTerminationsCfg code in G1 and H1 RoughEnvCfg
jtigue-bdai
approved these changes
Dec 4, 2024
SevenFo
pushed a commit
to SevenFo/IsaacLab
that referenced
this pull request
May 19, 2025
…saac-sim#1484) # Description `TerminationsCfg` is the same as `LocomotionVelocityRoughEnvCfg`, there is no need to configure it again, just modify the corresponding name `self.terminations.base_contact.params["sensor_cfg"].body_names` ## Type of change - Bug fix (non-breaking change which fixes an issue) ## Checklist - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with `./isaaclab.sh --format` - [ ] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] I have updated the changelog and the corresponding version in the extension's `config/extension.toml` file - [x] I have added my name to the `CONTRIBUTORS.md` or my name already exists there Co-authored-by: Kelly Guo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
TerminationsCfgis the same asLocomotionVelocityRoughEnvCfg, there is no need to configure it again, just modify the corresponding nameself.terminations.base_contact.params["sensor_cfg"].body_namesType of change
Checklist
pre-commitchecks with./isaaclab.sh --formatconfig/extension.tomlfileCONTRIBUTORS.mdor my name already exists there