Improve omni.isaac.lab_tasks loading time #1353
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Toni-SM
requested review from
Dhoeller19,
Mayankm96,
jsmith-bdai,
jtigue-bdai and
kellyguo11
as code owners
kellyguo11
approved these changes
Nov 4, 2024
kellyguo11
approved these changes
Nov 4, 2024
kemjensak
added a commit
to IROL-SSU/IsaacLab_Old
that referenced
this pull request
Nov 5, 2024
iamdrfly
pushed a commit
to iamdrfly/IsaacLab
that referenced
this pull request
Nov 21, 2024
# Description Improve omni.isaac.lab_tasks loading time (13th Gen Intel® Core™ i9-13950HX × 32) * Before: 3.66 seconds * After: 84 milliseconds ## Screenshots Original (no changes)  Define task entry points as string when registering  Define task entry points as string when registering + Ignore `mdp` directories during import.  ## Checklist - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with `./isaaclab.sh --format` - [ ] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [x] I have updated the changelog and the corresponding version in the extension's `config/extension.toml` file - [x] I have added my name to the `CONTRIBUTORS.md` or my name already exists there <!-- As you go through the checklist above, you can mark something as done by putting an x character in it For example, - [x] I have done this task - [ ] I have not done this task --> --------- Co-authored-by: Mayank Mittal <[email protected]> Co-authored-by: Kelly Guo <[email protected]> Co-authored-by: Kelly Guo <[email protected]>
adrian-sch
pushed a commit
to adrian-sch/IsaacLab
that referenced
this pull request
Dec 6, 2024
# Description Improve omni.isaac.lab_tasks loading time (13th Gen Intel® Core™ i9-13950HX × 32) * Before: 3.66 seconds * After: 84 milliseconds ## Screenshots Original (no changes)  Define task entry points as string when registering  Define task entry points as string when registering + Ignore `mdp` directories during import.  ## Checklist - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with `./isaaclab.sh --format` - [ ] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [x] I have updated the changelog and the corresponding version in the extension's `config/extension.toml` file - [x] I have added my name to the `CONTRIBUTORS.md` or my name already exists there <!-- As you go through the checklist above, you can mark something as done by putting an x character in it For example, - [x] I have done this task - [ ] I have not done this task --> --------- Co-authored-by: Mayank Mittal <[email protected]> Co-authored-by: Kelly Guo <[email protected]> Co-authored-by: Kelly Guo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Improve omni.isaac.lab_tasks loading time
(13th Gen Intel® Core™ i9-13950HX × 32)
Screenshots
Original (no changes)
Define task entry points as string when registering
Define task entry points as string when registering + Ignore
mdpdirectories during import.Checklist
pre-commitchecks with./isaaclab.sh --formatconfig/extension.tomlfileCONTRIBUTORS.mdor my name already exists there