-
Notifications
You must be signed in to change notification settings - Fork 2.6k
Adds recorder manager in manager-based environments #1336
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
37b6d9c to
62087f0
Compare
0e16d99 to
18f8f71
Compare
kellyguo11
reviewed
Nov 17, 2024
source/extensions/omni.isaac.lab/omni/isaac/lab/envs/manager_based_env.py
Outdated
Show resolved
Hide resolved
source/extensions/omni.isaac.lab/omni/isaac/lab/envs/manager_based_rl_env.py
Outdated
Show resolved
Hide resolved
source/extensions/omni.isaac.lab/omni/isaac/lab/envs/manager_based_rl_env.py
Outdated
Show resolved
Hide resolved
source/extensions/omni.isaac.lab/omni/isaac/lab/managers/recorder_manager.py
Outdated
Show resolved
Hide resolved
source/extensions/omni.isaac.lab/omni/isaac/lab/managers/recorder_manager.py
Outdated
Show resolved
Hide resolved
source/extensions/omni.isaac.lab/omni/isaac/lab/scene/interactive_scene.py
Outdated
Show resolved
Hide resolved
source/extensions/omni.isaac.lab/test/managers/test_recorder_manager.py
Outdated
Show resolved
Hide resolved
source/extensions/omni.isaac.lab/test/utils/test_episode_data.py
Outdated
Show resolved
Hide resolved
source/extensions/omni.isaac.lab/omni/isaac/lab/envs/manager_based_env.py
Outdated
Show resolved
Hide resolved
Contributor
|
test_episode_data.py test seems to be failing |
jtigue-bdai
reviewed
Nov 18, 2024
source/extensions/omni.isaac.lab/omni/isaac/lab/envs/manager_based_env.py
Outdated
Show resolved
Hide resolved
source/extensions/omni.isaac.lab/omni/isaac/lab/scene/interactive_scene.py
Show resolved
Hide resolved
source/extensions/omni.isaac.lab/test/managers/test_recorder_manager.py
Outdated
Show resolved
Hide resolved
source/extensions/omni.isaac.lab/omni/isaac/lab/envs/mdp/recorders/recorders.py
Outdated
Show resolved
Hide resolved
source/extensions/omni.isaac.lab/omni/isaac/lab/managers/recorder_manager.py
Outdated
Show resolved
Hide resolved
source/extensions/omni.isaac.lab/omni/isaac/lab/scene/interactive_scene.py
Outdated
Show resolved
Hide resolved
source/extensions/omni.isaac.lab/omni/isaac/lab/scene/interactive_scene.py
Outdated
Show resolved
Hide resolved
source/extensions/omni.isaac.lab/omni/isaac/lab/scene/interactive_scene.py
Show resolved
Hide resolved
source/extensions/omni.isaac.lab/test/managers/test_recorder_manager.py
Outdated
Show resolved
Hide resolved
source/extensions/omni.isaac.lab/omni/isaac/lab/managers/recorder_manager.py
Outdated
Show resolved
Hide resolved
afde2dd to
3604590
Compare
fe7e5fe to
49d30cd
Compare
ea91b75 to
3cb1d1d
Compare
kellyguo11
reviewed
Dec 4, 2024
source/extensions/omni.isaac.lab/omni/isaac/lab/envs/manager_based_env.py
Show resolved
Hide resolved
source/extensions/omni.isaac.lab/omni/isaac/lab/scene/interactive_scene.py
Show resolved
Hide resolved
source/extensions/omni.isaac.lab/omni/isaac/lab/scene/interactive_scene.py
Show resolved
Hide resolved
Co-authored-by: Kelly Guo <[email protected]> Signed-off-by: CY Chen <[email protected]>
nvcyc
commented
Dec 4, 2024
Contributor
Author
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the reviews. Comments are addressed.
source/extensions/omni.isaac.lab/omni/isaac/lab/scene/interactive_scene.py
Show resolved
Hide resolved
source/extensions/omni.isaac.lab/omni/isaac/lab/scene/interactive_scene.py
Show resolved
Hide resolved
source/extensions/omni.isaac.lab/omni/isaac/lab/envs/manager_based_env.py
Show resolved
Hide resolved
jtigue-bdai
approved these changes
Dec 4, 2024
Collaborator
jtigue-bdai
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for new feature. LGTM
SevenFo
pushed a commit
to SevenFo/IsaacLab
that referenced
this pull request
May 19, 2025
# Description <!-- Thank you for your interest in sending a pull request. Please make sure to check the contribution guidelines. Link: https://isaac-sim.github.io/IsaacLab/source/refs/contributing.html --> This PR adds a recorder manager (RecorderManager) and relevant utility classes for recording data produced in various reset and step stages in manager-based environments. Wither the built-in recorder manager, users can create custom recorder terms in their environment configurations with callback functions returning tensors to be recorded as environments advance. It is particularly useful for implementing an app that collects human-operated demos and for those who want to record robot actions for post-validation/replay in Isaac Lab environments. The recorder manager works in both single- and multi-environment use cases. An episode for an environment instance is exported to a dataset file, via a dataset file handler, upon completion (a termination term is signaled a reset to the environment instance is triggered). By default, the recorder manager is inactive (by assigning no recorder terms in the default configuration), which should have minimal performance impact for existing apps that do not require data recording. ## Type of change <!-- As you go through the list, delete the ones that are not applicable. --> - New feature (non-breaking change which adds functionality) - This change requires a documentation update -- to be updated in later PRs ## Checklist - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with `./isaaclab.sh --format` - [ ] I have made corresponding changes to the documentation - [ ] My changes generate no new warnings - [x] I have added tests that prove my fix is effective or that my feature works - [x] I have updated the changelog and the corresponding version in the extension's `config/extension.toml` file - [x] I have added my name to the `CONTRIBUTORS.md` or my name already exists there <!-- As you go through the checklist above, you can mark something as done by putting an x character in it For example, - [x] I have done this task - [ ] I have not done this task --> --------- Signed-off-by: CY Chen <[email protected]> Co-authored-by: Kelly Guo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a recorder manager (RecorderManager) and relevant utility classes for recording data produced in various reset and step stages in manager-based environments.
Wither the built-in recorder manager, users can create custom recorder terms in their environment configurations with callback functions returning tensors to be recorded as environments advance. It is particularly useful for implementing an app that collects human-operated demos and for those who want to record robot actions for post-validation/replay in Isaac Lab environments.
The recorder manager works in both single- and multi-environment use cases. An episode for an environment instance is exported to a dataset file, via a dataset file handler, upon completion (a termination term is signaled a reset to the environment instance is triggered).
By default, the recorder manager is inactive (by assigning no recorder terms in the default configuration), which should have minimal performance impact for existing apps that do not require data recording.
Type of change
Checklist
pre-commitchecks with./isaaclab.sh --formatconfig/extension.tomlfileCONTRIBUTORS.mdor my name already exists there