Ensures mesh name is compatible with USD convention in mesh converter #1302
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
I just simplified the processing logic and removed useless intermediate variables |
Mayankm96
reviewed
Oct 31, 2024
source/extensions/omni.isaac.lab/omni/isaac/lab/sim/converters/mesh_converter.py
Outdated
Show resolved
Hide resolved
…/mesh_converter.py Co-authored-by: Mayank Mittal <[email protected]> Signed-off-by: robotsfan <[email protected]>
Dhoeller19
reviewed
Oct 31, 2024
source/extensions/omni.isaac.lab/omni/isaac/lab/sim/converters/mesh_converter.py
Outdated
Show resolved
Hide resolved
…/mesh_converter.py Signed-off-by: David Hoeller <[email protected]>
Dhoeller19
reviewed
Oct 31, 2024
source/extensions/omni.isaac.lab/omni/isaac/lab/sim/converters/mesh_converter.py
Outdated
Show resolved
Hide resolved
added 2 commits
October 31, 2024 15:41
…/mesh_converter.py Signed-off-by: David Hoeller <[email protected]>
Dhoeller19
changed the title
iamdrfly
pushed a commit
to iamdrfly/IsaacLab
that referenced
this pull request
Nov 21, 2024
…isaac-sim#1302) # Description Fixes isaac-sim#1287 **Issue details**: When using the convert_mesh.py script to convert .obj to .usd, if the obj file in this scene starts with a number(0c334eaabb844eaaad049cbbb2e0a4f2.obj), while the USD API prohibits names that start with a number [Link](https://openusd.org/release/api/group__group__tf___string.html#gaa129b294af3f68d01477d430b70d40c8). This issue is described in more detail here: [Link](https://forums.developer.nvidia.com/t/cant-create-prims-if-name-starts-with-number/249617). Also deleted useless debugging output code. ## Type of change - Bug fix (non-breaking change which fixes an issue) ## Checklist - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with `./isaaclab.sh --format` - [ ] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [x] I have added tests that prove my fix is effective or that my feature works - [ ] I have updated the changelog and the corresponding version in the extension's `config/extension.toml` file - [x] I have added my name to the `CONTRIBUTORS.md` or my name already exists there
adrian-sch
pushed a commit
to adrian-sch/IsaacLab
that referenced
this pull request
Dec 6, 2024
…isaac-sim#1302) # Description Fixes isaac-sim#1287 **Issue details**: When using the convert_mesh.py script to convert .obj to .usd, if the obj file in this scene starts with a number(0c334eaabb844eaaad049cbbb2e0a4f2.obj), while the USD API prohibits names that start with a number [Link](https://openusd.org/release/api/group__group__tf___string.html#gaa129b294af3f68d01477d430b70d40c8). This issue is described in more detail here: [Link](https://forums.developer.nvidia.com/t/cant-create-prims-if-name-starts-with-number/249617). Also deleted useless debugging output code. ## Type of change - Bug fix (non-breaking change which fixes an issue) ## Checklist - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with `./isaaclab.sh --format` - [ ] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [x] I have added tests that prove my fix is effective or that my feature works - [ ] I have updated the changelog and the corresponding version in the extension's `config/extension.toml` file - [x] I have added my name to the `CONTRIBUTORS.md` or my name already exists there
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #1287
Issue details: When using the convert_mesh.py script to convert .obj to .usd, if the obj file in this scene starts with a number(0c334eaabb844eaaad049cbbb2e0a4f2.obj), while the USD API prohibits names that start with a number Link. This issue is described in more detail here: Link.
Also deleted useless debugging output code.
Type of change
Screenshots
Please attach before and after screenshots of the change if applicable.
Checklist
pre-commitchecks with./isaaclab.sh --formatconfig/extension.tomlfileCONTRIBUTORS.mdor my name already exists there