Skip to content

Conversation

@SteAmeR
Copy link
Contributor

@SteAmeR SteAmeR commented Sep 26, 2025

  • Problem Many legitimate Office files (created by Google Docs, Wine-based applications) fail to open due to strict ModifiedTime validation for streams.

  • Solution Move ModifiedTime validation under #if STRICT directive, consistent with existing CreationTime validation approach.

- Problem
Many legitimate Office files (created by Google Docs, Wine-based applications) fail to open due to strict ModifiedTime validation for streams.

- Solution
Move ModifiedTime validation under `#if STRICT` directive, consistent with existing CreationTime validation approach.
@jeremy-visionaid jeremy-visionaid changed the title Update CfbBinaryReader.cs Relax directory entry modification time validation Sep 26, 2025
@jeremy-visionaid
Copy link
Collaborator

@SteAmeR Are you able to provide steps to create the sample file? I'd like to include a sample for the unit tests if/when strict validation gets implemented, but I'd rather include one that I created myself so I can label the client origin etc. if that's OK?

@SteAmeR
Copy link
Contributor Author

SteAmeR commented Sep 26, 2025

Just to clarify, under issue #312 I explained the reason why I requested this PR — it is mainly to avoid unnecessary exceptions when reading real-world legacy files that don’t strictly follow the MS-CFB spec but are still accepted by Word/LibreOffice. If possible, I’d kindly ask you to consider merging this PR, as it would help make OpenMCDF more tolerant in read/view scenarios while keeping strict validation available for file creation.

Thanks again for your efforts on maintaining this project.

@jeremy-visionaid jeremy-visionaid merged commit 3574847 into ironfede:master Nov 17, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants