BUG sphinxext: ensure sys.stdout is used for logging (#10904) #10907
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! This looks fine to me, following our discussion in #10904. I think it's fine not to add tests in this PR, but if you wanted to add some as a separate PR, that would be welcome. |
|
Yes, I am doing a PR to sphinx itself now as well, and looking how they do tests. If that's not too hard to do something similar here, I will try that. |
15 tasks
takluyver
added a commit
that referenced
this pull request
Nov 17, 2017
Backport PR #10907 on branch 5.x
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #10904
Didn't add tests, as I think there are no tests for the sphinxext? (and adding is probably quite a bit more complicated than this fix)