chore: omit lockfile from release commit #126
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Turns out ignoring `.gitignore` while adding files to the release commit is a feature not a bug so specify the list of files to add. Refs: semantic-release/git#56 We can probably revert if semantic-release/git#527 ever gets merged.
rvagg
approved these changes
May 12, 2025
rvagg
added a commit
to multiformats/js-multiformats
that referenced
this pull request
May 20, 2025
rvagg
added a commit
to multiformats/js-multiformats
that referenced
this pull request
May 20, 2025
rvagg
added a commit
to multiformats/js-multiformats
that referenced
this pull request
May 20, 2025
rvagg
added a commit
to multiformats/js-multiformats
that referenced
this pull request
May 20, 2025
rvagg
added a commit
to multiformats/js-multiformats
that referenced
this pull request
May 21, 2025
rvagg
added a commit
to ipld/js-dag-pb
that referenced
this pull request
May 21, 2025
github-actions bot
pushed a commit
that referenced
this pull request
May 22, 2025
## [9.2.4](v9.2.3...v9.2.4) (2025-05-22) ### Bug Fixes * address lint errors ([467d98c](467d98c)) ### Trivial Changes * omit lockfile from release commit ([#126](#126)) ([2013bda](2013bda)) * remove package-lock ([6445f53](6445f53)) ### Dependencies * **dev:** bump aegir from 46.0.5 to 47.0.10 ([c0b2879](c0b2879))
|
🎉 This PR is included in version 9.2.4 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns out ignoring
.gitignorewhile adding files to the release commit is a feature not a bug so specify the list of files to add.We didn't trigger it in the past because we didn't add the lockfile to the build cache so it wasn't copied into the container for the release build step. Now we do in order to support projects (like apps) that want a lockfile so we need to specify the asset files in the config.
Refs: semantic-release/git#56
We can probably revert/update if semantic-release/git#527 ever gets merged.