This repository was archived by the owner on Feb 8, 2023. It is now read-only.
Create 2018-12-05--gui-and-in-web-browsers-weekly.md #789
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned
Contributor
Author
|
Can I get push access to this repo so I don't have to fork? // cc'ing as I can't assign reviewers: @olizilla @lidel @hacdias @alanshaw @terichadbourne |
daviddias
reviewed
Dec 6, 2018
|
|
||
| - @terichadbourne | ||
| - Done: | ||
| - Opened an issue proposing a workshop using the file API (rather than DAG API) for ProtoSchool. (All current workshops use the DAG API so it’s not being surfaced that file transfer is possible.) Open to suggestions and feedback at https://github.com/ipfs-shipyard/proto.school/issues/91 |
Member
There was a problem hiding this comment.
That would be great! A lot of people get confused between the Files API with the DAG API and the Block API
daviddias
reviewed
Dec 6, 2018
| - Replace distribution of peers graph in webui with repo size information. Limit geolocations to peers page to avoid gratuitous system load. | ||
| - Cut a release of Web UI | ||
| - PR go-ipfs to add webui link to ipfs daemon output. | ||
| - GET DESKTOP RELEASED 🚢 ✨ |
Member
There was a problem hiding this comment.
No. Most of the time available has gone on
- Dealing with errors where a previous ifps deaemon wasn't shutdown properly feat: cleanup repository before starting up IPFS ipfs-desktop#722 - this ment the app would fail to start if the user previously ran
ipfs daemonmanually, and didn't wait for the process to shutdown gracefully when exiting. - Dealing with issues related to CORS that was raised during reviews of the unclean startup PR. We were initially editing the users node config to include a CORS origin for webui://- which is the fake scheme under which we serve the webui from within the electron app. We then decided that we didn't want to leave the user with a node config that included a CORS origin that would live on beyond the life of the app, as we can't predict how it could be abused in the future.
- So @hacdias refactored to proxying ipfs but a quick test showed that it crashed the electron webview on large files. This is probably fixable, but we decided to keep things simple and disable CORS checks for the webview, as we are in control of the window and the webui code. As a precuation we are enabling the other electron security recommendations in feat: improve security of electron app ipfs-desktop#741
I'd like to have a pre-release this afternoon, though it looks like it will have to be tomorrow now, and get it installed on gui team machines, so we can test out the auto-update mechanism, and then invite the IPFS org to give it a go.
Member
There was a problem hiding this comment.
Thank you for the super complete status update. ❤️ @olizilla
alanshaw
approved these changes
Dec 6, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc #790