fix(ci): make NewRandPort thread-safe #10921
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tests were failing intermittently. Disabling AutoTLS when WebSocket transport is disabled appears to resolve the issue.
Track allocated ports globally to prevent conflicts when tests run in parallel.
Member
Author
|
Merging as this is just making tests less flaky, so good to have before we start release builds. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
NewRandPort()function had a race condition where it would close a TCP listener after getting its port number, allowing parallel test goroutines to claim the same "available" port before it was actually used, causing "address already in use" errors like one in: