This repository was archived by the owner on Feb 12, 2024. It is now read-only.
chore: simplify streaming http response code and use instances of pubsub tracker instead of a singleton #3719
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Node 16 has broken something in Hapi that means `h.response(stream)` no longer works. The change is to use `h.abandon` and skip Hapi's stream parsing and manage writing into the raw response stream ourselves. Fixes the build problems seen in ipfs/interop#316
achingbrain
changed the title
This was referenced Sep 13, 2021
This was referenced Oct 15, 2021
This was referenced Feb 7, 2022
SgtPooki
referenced
this pull request
in ipfs/js-kubo-rpc-client
Aug 18, 2022
…sub tracker instead of a singleton (#3719) Simplifies deps, pass peer id as string instead of cid.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplifies deps, pass peer id as string instead of cid.