This repository was archived by the owner on Feb 12, 2024. It is now read-only.
fix: files.add with pull streams + ability to seek #1319
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned
This was referenced Apr 20, 2018
Member
|
I understand that this PR needs the latest of js-ipfs-api. I'm having a hard time releasing js-ipfs-api. Too many timeouts. Wanna take a look at that? |
Member
Author
|
Sure, I'll take a look now |
Member
Author
|
Ok so, for
|
Member
daviddias
force-pushed
the
fix/files.add-pull-streams
branch
from
84509c2 to
6b424a0
Compare
daviddias
force-pushed
the
fix/files.add-pull-streams
branch
from
6b424a0 to
6248cac
Compare
Member
|
@alanshaw something is not working properly in this PR. |
Member
Author
|
According to the CI the failing tests are to do with |
daviddias
suggested changes
May 1, 2018
package.json
Outdated
| "form-data": "^2.3.2", | ||
| "hat": "0.0.3", | ||
| "interface-ipfs-core": "^0.61.0", | ||
| "interface-ipfs-core": "^0.64.2", |
Member
Author
|
@diasdavid yes that's it - the tests are failing because the new |
This was referenced May 1, 2018
…o request slices of files feat: Allows for byte offsets when using ipfs.files.cat and friends to request slices of files
daviddias
changed the title
Member
|
@diasdavid CI seems happy with this now but some of our (unrelated to this PR) tests time out occasionally. |
daviddias
reviewed
May 3, 2018
circle.yml
Outdated
| # Warning: This file is automatically synced from https://github.com/ipfs/ci-sync so if you want to change it, please change it there and ask someone to sync all repositories. | ||
| machine: | ||
| node: | ||
| version: 9 |
daviddias
approved these changes
May 3, 2018
daviddias
approved these changes
May 6, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1317
tested by ipfs-inactive/interface-js-ipfs-core#256