Can't disable preload for CLI daemon

[victorb]

• Version: js-ipfs version: 0.31.7
• Platform: Linux 4.18.5-arch1-1-ARCH Add to cli: ipfs pin [-r] <ipfs-path> #1 SMP PREEMPT Fri Aug 24 12:48:58 UTC 2018 x86_64 GNU/Linux
• Subsystem: Preload

Type:

Bug

Severity:

Low

Description:

Can't disable preloading when running the daemon via the CLI. Even with preload.enabled set to false, the daemon seems to not respect it and when adding data, automatically does the preloading requests.

Steps to reproduce the error:

$ export IPFS_PATH=/tmp/tmp.1MVJtmJWT0
$ node src/cli/bin.js init
$ node src/cli/bin.js config --bool preload.enabled false
$ node src/cli/bin.js config preload.enabled
false
$ jq .preload $IPFS_PATH/config
{
  "enabled": false
}

$ # run daemon with debug to see if preloading is happening
$ DEBUG=jsipfs:preload node src/cli/bin.js daemon

Now in new terminal window

$ export IPFS_PATH=/tmp/tmp.1MVJtmJWT0
$ node src/cli/bin.js add -r node_modules/async # can be anything, just add it

And look back in the first terminal window, there will be bunch of preloading happening, even though preloading is supposed to be off.

[victorb]

Initially thought that #1372 would fix it, but after applying that change, this still happens so seems to be something specific with preloading config.

[victorb]

Might have something to do with this

js-ipfs/src/core/components/block.js

Lines 28 to 30 in 46222e1

	if (options.preload !== false) {
	self._preload(cid)
	}

Appears in a couple of places

https://github.com/ipfs/js-ipfs/search?q=%22options.preload+%21%3D%3D+false%22&unscoped_q=%22options.preload+%21%3D%3D+false%22

[parkan]

we'd like to be able to turn off preloading for debugging purposes in the IA integration (and because the client is likely not connected to ipfs.io, making preloads useless)

is this broken in browser, as well?

[victorb]

@parkan my guess is yes (but I have not tried it myself) as the checks are in the components/ itself, not the CLI nor HTTP API.