-
Notifications
You must be signed in to change notification settings - Fork 51
fix: human readable option #213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Can I get a second review here, please? @achingbrain @hugomrdias @jacobheun |
|
Released in v0.29.1 |
|
I'd like to keep formatting functionality out of ipfs core - it bloats the bundle size, makes assumptions about locale and can be easily added by applications using IPFS. What do you think? I'd be in favour of removing this functionality altogether and pushing it into the CLI and HTTP API resources. |
|
I got your point. It makes sense. What do you think @achingbrain @jacobheun? |
This sounds like a good approach to me. |
|
Me too, formatting is a UI concern. |
This PR fixes the output of
humanoption that can be passed torepo.stat ([options]).Both
repoSizeandstorageMaxproperties of the returned object are now according togoimplementation:repoSize-> represented inMBstorageMax-> represented inGBExample:
Closes ipfs/js-ipfs#1996.