fix: reset batch size counter #175
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a batch of blocks was sent, the counter for the calculating the size wasn't reset. After the initial batch, every message was sent individually, which lead to a performance bottleneck. With this change receiving larger files (> 2MiB) is about 30% faster.
ghost
assigned
daviddias
approved these changes
May 20, 2018
Member
|
thank you for catching this @vmx! |
30 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a batch of blocks was sent, the counter for the calculating
the size wasn't reset. After the initial batch, every message was
sent individually, which lead to a performance bottleneck. With
this change receiving larger files (> 2MiB) is about 30% faster.