feat! switch to sync api #7
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I end up building a new importer that uses sync API for building DAGs and this is a fork which makes hamt-sharding sync by requiring
SyncMultihashHasher
introduced by multiformats/js-multiformats#160.It also makes use of (version locked) sync murmur hasher introduced by multiformats/js-murmur3#17
I do not know if landing this changes make sense at all, it may make more sense to release this as separate library or maybe sync API can be provided along the side of current async API. Mostly this PR is here to start this conversation. Furthermore I do want to revamp hash-sharding library to simplify it make bit less stateful, I have WIP branch for this, but I have decided to pause that to finish up the new importer first.