Skip to content

Conversation

Gozala
Copy link

@Gozala Gozala commented Jan 27, 2022

I end up building a new importer that uses sync API for building DAGs and this is a fork which makes hamt-sharding sync by requiring SyncMultihashHasher introduced by multiformats/js-multiformats#160.

It also makes use of (version locked) sync murmur hasher introduced by multiformats/js-murmur3#17

I do not know if landing this changes make sense at all, it may make more sense to release this as separate library or maybe sync API can be provided along the side of current async API. Mostly this PR is here to start this conversation. Furthermore I do want to revamp hash-sharding library to simplify it make bit less stateful, I have WIP branch for this, but I have decided to pause that to finish up the new importer first.

@Gozala
Copy link
Author

Gozala commented Jan 27, 2022

P.S. Can I get access to this repo, I had to fork it into my namespace to submit a PR

@BigLep
Copy link

BigLep commented Jan 28, 2022

@Gozala : per 2022-01-28 triage, a few things:

  1. You now have access to this repo.
  2. In terms of code reviewing this, we'll leave that to you and Nitro whether this is worth doing. If it is worth doing, can you have Alen code review please? As I understand, it sounds like Nitro was able to get unblocked via other means.
  3. The PR needs to have the title "feat!:" (it's currently missing the ":")

@BigLep BigLep added the need/author-input Needs input from the original author label Jan 28, 2022
@lidel
Copy link
Member

lidel commented Feb 18, 2022

@Gozala any chance you will have time to finish this?

@lidel
Copy link
Member

lidel commented Mar 11, 2022

Feel free reopen when you have time to finish / find this still relevant.

@lidel lidel closed this Mar 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
need/author-input Needs input from the original author
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants