Fix Chromium crash on 150MB upload #596
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Switches to stream-http with a fix. Context: #464
Member
Author
|
Companion uses yarn anyway (for reproducible builds), so let's go with this as-is. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes #464 (crash when dropping a big file) by switching to stream-http with this fix by @hugomrdias ✨ 👍
TL;DR it makes this go away when user uploads >150MB in Chromium-based browser to external node over js-ipfs-api.
More context: #464
cc @ipfs-shipyard/gui as this is a highly relevant fix for WebUI / Share app and possibly Desktop too.
Note: in Companion I am able to use yarn-specific resolutions to force specific version of transitive dependency.
This fix will eventually get released and will land in js-ipfs-api.
I plan to remove it from
resolutionswhen that happens.