-
Notifications
You must be signed in to change notification settings - Fork 134
feat: allow modifying trustless-gateway fetch #751
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
SgtPooki
merged 8 commits into
main
from
feat/allow-modifying-trustless-gateway-fetch-options
Mar 10, 2025
Merged
Changes from 6 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
440e176
feat: add support for custom headers in trustless gateway
pcfreak30 fbf8e68
chore: allow test trustless gateway server introspection
SgtPooki 73545e4
feat: allow modification of fetch options to trustless gateway
SgtPooki 8f92580
chore: apply self suggestions from code review
SgtPooki 93601bc
Merge branch 'main' into feat/allow-modifying-trustless-gateway-fetch…
SgtPooki cd1f716
chore: new header test passes
SgtPooki 141fd93
test: fix headers test and remove unused arg
SgtPooki f0bb569
chore: add transformRequestInit to options object
SgtPooki File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,7 +1,7 @@ | ||
| import { isPrivateIp } from '@libp2p/utils/private-ip' | ||
| import { DNS, HTTP, HTTPS } from '@multiformats/multiaddr-matcher' | ||
| import { multiaddrToUri } from '@multiformats/multiaddr-to-uri' | ||
| import { TrustlessGateway } from './trustless-gateway.js' | ||
| import { TrustlessGateway, type TransformRequestInit } from './trustless-gateway.js' | ||
| import type { Routing } from '@helia/interface' | ||
| import type { ComponentLogger } from '@libp2p/interface' | ||
| import type { AbortOptions, Multiaddr } from '@multiformats/multiaddr' | ||
|
|
@@ -33,7 +33,7 @@ export function filterNonHTTPMultiaddrs (multiaddrs: Multiaddr[], allowInsecure: | |
| }) | ||
| } | ||
|
|
||
| export async function * findHttpGatewayProviders (cid: CID, routing: Routing, logger: ComponentLogger, allowInsecure: boolean, allowLocal: boolean, options?: AbortOptions): AsyncGenerator<TrustlessGateway> { | ||
| export async function * findHttpGatewayProviders (cid: CID, routing: Routing, logger: ComponentLogger, allowInsecure: boolean, allowLocal: boolean, transformRequestInit?: TransformRequestInit, options: AbortOptions = {}): AsyncGenerator<TrustlessGateway> { | ||
|
||
| for await (const provider of routing.findProviders(cid, options)) { | ||
| // require http(s) addresses | ||
| const httpAddresses = filterNonHTTPMultiaddrs(provider.multiaddrs, allowInsecure, allowLocal) | ||
|
|
@@ -48,6 +48,6 @@ export async function * findHttpGatewayProviders (cid: CID, routing: Routing, lo | |
| // etc | ||
| const uri = multiaddrToUri(httpAddresses[0]) | ||
|
|
||
| yield new TrustlessGateway(uri, logger) | ||
| yield new TrustlessGateway(uri, { logger, transformRequestInit }) | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.