fix: use unixfs exporter to traverse DAGs #455
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reuse the existing exporter `walkPath` method to traverse a DAG as it is clever enough to not load unecessary blocks which is important when traversing HAMTs.
This was referenced Feb 27, 2024
SgtPooki
approved these changes
Feb 27, 2024
Member
SgtPooki
left a comment
SgtPooki
left a comment
There was a problem hiding this comment.
Lgtm. I knew it should have been easier than Adin and I were making it out to be
Comment on lines
+125
to
+128
| // should be able to cat the index file without loading the other files | ||
| // in the shard - the blockstore is offline so will throw if requested | ||
| // blocks are not present | ||
| const bytes = await toBuffer(fs.cat(dir.cid, { |
Comment on lines
+41
to
46
| const p = `/ipfs/${cid}${path == null ? '' : `/${path}`}` | ||
| const segments = await all(walkPath(p, blockstore, options)) | ||
|
|
||
| if (segments.length === 0) { | ||
| throw new DoesNotExistError('Could not find path in directory') | ||
| } |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reuse the existing exporter
walkPathmethod to traverse a DAG as it is clever enough to not load unnecessary blocks which is important when traversing HAMTs.Change checklist