fix: verified-fetch etag header #434
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lidel
approved these changes
Feb 14, 2024
Co-authored-by: Marcin Rataj <[email protected]>
achingbrain
reviewed
Feb 15, 2024
Co-authored-by: Alex Potsides <[email protected]>
SgtPooki
commented
Feb 15, 2024
Member
Author
SgtPooki
left a comment
SgtPooki
left a comment
There was a problem hiding this comment.
self review. should have done this yesterday. my bad. should be good to go now
achingbrain
approved these changes
Feb 16, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes some issues with the etag header
FYI:I needed toshould handle identity CIDtest is failing for me locally, even onmainbranch. no idea why. Inpm run clean && npm i && npm run testand still get the failurenpm run clean && npm ifrom the monorepo root.