Skip to content

Conversation

@hsanjuan
Copy link
Contributor

Assuming that the stack might get a Connected notification, but we have not yet started pinging.

Attempting to send a message at that moment fails, the messagequeue shutdown as a result, but no disconnect/connect happens from that point as it expects.

Also add some logging to see if we are hitting those message sender exists.

Assuming that the stack might get a Connected notification,
but we have not yet started pinging.

Attempting to send a message at that moment fails, the messagequeue shutdown as a result, but no disconnect/connect happens from that point as it expects.

Also add some logging to see if we are hitting those message sender exists.
@hsanjuan hsanjuan self-assigned this Jul 18, 2025
@hsanjuan hsanjuan requested a review from a team as a code owner July 18, 2025 21:11
@codecov
Copy link

codecov bot commented Jul 18, 2025

Codecov Report

Attention: Patch coverage is 66.66667% with 2 lines in your changes missing coverage. Please review.

Project coverage is 61.53%. Comparing base (2cf77c4) to head (29a80b6).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
bitswap/network/httpnet/httpnet.go 66.66% 2 Missing ⚠️

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #982   +/-   ##
=======================================
  Coverage   61.52%   61.53%           
=======================================
  Files         254      254           
  Lines       31490    31491    +1     
=======================================
+ Hits        19375    19378    +3     
  Misses      10526    10526           
+ Partials     1589     1587    -2     
Files with missing lines Coverage Δ
bitswap/network/httpnet/httpnet.go 64.60% <66.66%> (+0.27%) ⬆️

... and 7 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@hsanjuan hsanjuan merged commit 41fc930 into main Jul 18, 2025
16 of 17 checks passed
@hsanjuan hsanjuan deleted the httpnet-connect-disconnect branch July 18, 2025 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants