bitswap/client: disable use of traceability block by default #956
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The bitswap client's [`traceability.Block`](https://github.com/ipfs/boxo/blob/main/bitswap/client/traceability/block.go) is now disabled by default. It is only used for testing an debugging and is not needed for typical operation. Using it costs additional allocation. To enable `traceability.Block`, use the bitswap client option `WithTraceBlock(true)`.
Codecov ReportAll modified and coverable lines are covered by tests ✅
@@ Coverage Diff @@
## main #956 +/- ##
==========================================
+ Coverage 61.54% 61.58% +0.03%
==========================================
Files 254 254
Lines 31493 31504 +11
==========================================
+ Hits 19382 19401 +19
+ Misses 10521 10518 -3
+ Partials 1590 1585 -5
... and 8 files with indirect coverage changes 🚀 New features to boost your workflow:
|
guillaumemichel
approved these changes
Jul 23, 2025
Contributor
guillaumemichel
left a comment
guillaumemichel
left a comment
There was a problem hiding this comment.
LGTM! A few nits
Co-authored-by: Guillaume Michel <[email protected]>
Co-authored-by: Guillaume Michel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bitswap client's
traceability.Blockis now disabled by default. It is only used for testing and debugging and is not needed for typical operation. Using it costs additional allocation. To enabletraceability.Block, use the bitswap client optionWithTraceBlock(true).