feat: enforce package.json dependency version guidelines #231
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned
achingbrain
force-pushed
the
lint-package-json-dep-versions
branch
from
be9a3a9 to
64667ad
Compare
dryajov
approved these changes
May 21, 2018
Member
dryajov
left a comment
dryajov
left a comment
There was a problem hiding this comment.
LGTM! Thanks, this should help preventing our issues with the semantic version flags getting changed around randomly.
Member
Author
|
Do you think it might be a good idea to allow people to pin specific version numbers? In case a third party dep is released with a bug or a breaking change without revving the major version? |
Member
|
Yeah, that sounds about right. Also, maybe we can even provide a whitelist override - some packages might overload the |
Member
Author
|
I've added a new commit that allows pinned versions (e.g. |
Our JS code guidelines say we should use `~` as a prefix for pre-v1 dependencies. Sadly npm disagrees and uses `^` by default. This PR adds a linting step that examines all dependencies and strenuously objects if it sees anything that violates the guidelines. https://github.com/ipfs/community/blob/master/js-code-guidelines.md#dependency-versions feat: allow pinned versions for dependencies also refactors tests to test more scenarios
achingbrain
force-pushed
the
lint-package-json-dep-versions
branch
from
a5da68d to
47a0080
Compare
This was referenced May 22, 2018
Member
|
Nice! Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our JS code guidelines say we should use
~as a prefix for pre-v1 dependencies. Sadly npm disagrees and uses^by default.This PR adds a linting step that examines all dependencies and strenuously objects if it sees anything that violates the guidelines.
https://github.com/ipfs/community/blob/master/js-code-guidelines.md#dependency-versions