feat(examples): Add "Time locked account" account abstraction example #8602
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub. 6 Skipped Deployments
|
iota-ci
added
sc-platform
TheMrAI
force-pushed
the
vm-lang/aa-auth/8534-time-locked-account-example
branch
4 times, most recently
from
4675a96 to
ca3aa5c
Compare
Dkwcs
reviewed
Sep 25, 2025
TheMrAI
commented
Sep 25, 2025
examples/move/account_template/tests/account_template_tests.move
Outdated
Show resolved
Hide resolved
Dkwcs
reviewed
Sep 25, 2025
Dkwcs
reviewed
Sep 25, 2025
examples/move/account_template/tests/account_template_tests.move
Outdated
Show resolved
Hide resolved
Dkwcs
reviewed
Sep 25, 2025
Dkwcs
reviewed
Sep 25, 2025
Dkwcs
reviewed
Sep 25, 2025
TheMrAI
commented
Sep 26, 2025
valeriyr
reviewed
Sep 26, 2025
|
@TheMrAI I see that the |
Dkwcs
reviewed
Sep 29, 2025
TheMrAI
force-pushed
the
vm-lang/aa-auth/8534-time-locked-account-example
branch
from
73999ed to
7020334
Compare
TheMrAI
force-pushed
the
vm-lang/aa-auth/8534-time-locked-account-example
branch
from
58d3a8a to
d6190de
Compare
valeriyr
reviewed
Oct 10, 2025
borrow_uid remains until restructuring
The utility functions for building an account fulfill a completely different purpose from an actual account implementation. For this reason it makes sense to separate them as it makes it very clear what functionality may be problematic from a design perspective as well.
It muddies the interface, especially in terms of access control. Utility functions aren't concerned with access control, but all account functions should ensure that all access is correct. While in this case it doesn't change much, in more granular access controls it might become important if a clean pattern is established.
We named the module according to the name of the dynamic field struct. This is necessary to avoid name collisions within the testing framework while trying to compose multiple packages. package_A::name package_B::name package_C including both will collide, no matter if an alias or fully qualified names are used. In package_C one cannot override the address of pakcage_A or package_B either, so there is no convenient way to resolve collision.
These tests as the module are partial code duplications, but we don't want to refactor IOTAccount every time some new pattern should emerge. With this following refactor only has to remove the relevant code and tests from IOTAccount and transition to using these functions.
valeriyr
approved these changes
Oct 13, 2025
TheMrAI
merged commit 4c61aa5
into
vm-lang/aa-auth/8116-feature-branch
33 of 35 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Implement "Time locked account" example for abstract accounts.
This example explores the possibility of utilizing the authentication logic.
Each authenticator type can have a number of "reserved" dynamic fields and provide basic functions for attaching, detaching, rotating, checking and borrowing that type.
Properly using these functions is the responsibility of the implementer, but given the language restrictions this is a very flexible pattern.
Links to any relevant issues
fixes #8534
How the change has been tested