-
Notifications
You must be signed in to change notification settings - Fork 54
feat(iota_account): implementation of a Move package to represent a basic abstracted IOTA account #8250
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(iota_account): implementation of a Move package to represent a basic abstracted IOTA account #8250
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 6 Skipped Deployments
|
A verifier for validating `authenticate` functions introduced for `Move Authentication` (Account Abstraction). Contrary to other verifiers this shouldn't/can't be executed statically. This is why it doesn't appear among the list of other verifiers in: iota_verify_module_metered function. By design it has to be executed during runtime, as it is only executed for a single user specified function. The exact identity of this function will not be known until runtime.
Additionally all relevant components which lacked documentation have been updated.`
…l gas Otherwise we would need a new cut, which we don't want to have.
502da43 to
bd23d71
Compare
d4dfee1 to
52761af
Compare
2a17efb to
6ac6db5
Compare
52761af to
daaa870
Compare
TheMrAI
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
|
|
||
| /// Checks that the sender of this transaction is the account. | ||
| fun ensure_tx_sender_is_account(self: &IOTAccount, ctx: &TxContext) { | ||
| assert!(self.id.uid_to_address() == ctx.sender()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably I'm missing something, but I guess this assert is enough and we don't need any signature verification, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, this is a utility function just to check the sender address, nothing more.
theiari
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
I only left two small comments that are more like personal doubts.
a1b6c73 to
92d67ba
Compare
With this the drop function was removed as well.
9f9daca to
458aa71
Compare
…asic abstracted IOTA account
92d67ba to
aaa3a95
Compare
…th/8238-basic-abstracted-IOTA-account
25f4b30
into
vm-lang/aa-auth/8116-feature-branch
Description of change
A new Move type has been introduced:
What can we do with the introduced account:
Links to any relevant issues
Fixes #8238 .