-
Notifications
You must be signed in to change notification settings - Fork 58
refactor(iota-types): rename TransactionEffectsV2 to TransactionEffectsV1
#3662
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(iota-types): rename TransactionEffectsV2 to TransactionEffectsV1
#3662
Conversation
|
This pull request has been deployed to Vercel. Latest commit: a181042 ✅ Preview: https://apps-ui-3f5tf0m6e-iota1.vercel.app |
|
This pull request has been deployed to Vercel. Latest commit: a181042 ✅ Preview: https://apps-backend-29a719c9ccbdb9b80c97b599a599d8953354da-r02odmxit.vercel.app |
|
This pull request has been deployed to Vercel. Latest commit: a181042 ✅ Preview: https://wallet-dashboard-a225fcfa1e2f852205a61a7cd1d5d93e92-6hfw9uyzy.vercel.app |
|
This pull request has been deployed to Vercel. Latest commit: a181042 ✅ Preview: https://iota-rebased-explorer-092603f1de8088243ccb8b861b23e-g8c68ym4t.vercel.app |
|
Looks like the iota-light-client tests are broken now because the Ah I see #3665 is for this |
|
We have to keep in mind |
a9e2cf7
into
core-node/feat/remove-multiple-types-2
Description of change
This PR removes the
TransactionEffectsV1type as it is not used anymore during the execution.TransactionEffectsV2is then renamedTransactionEffectsV1.Links to any relevant issues
Closes #3657
Type of change
How the change has been tested
cargo run --release --bin iota start --force-regenesisChange checklist