Skip to content

Conversation

@miker83z
Copy link
Contributor

@miker83z miker83z commented Oct 25, 2024

Description of change

This PR removes the TransactionEffectsV1 type as it is not used anymore during the execution.
TransactionEffectsV2 is then renamed TransactionEffectsV1.

Links to any relevant issues

Closes #3657

Type of change

  • Enhancement (a non-breaking change which adds functionality)

How the change has been tested

  • cargo run --release --bin iota start --force-regenesis

Change checklist

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that new and existing unit tests pass locally with my changes

@miker83z miker83z requested review from a team and valeriyr as code owners October 25, 2024 10:05
@github-actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: a181042

✅ Preview: https://apps-ui-3f5tf0m6e-iota1.vercel.app

@github-actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: a181042

✅ Preview: https://apps-backend-29a719c9ccbdb9b80c97b599a599d8953354da-r02odmxit.vercel.app

@github-actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: a181042

✅ Preview: https://wallet-dashboard-a225fcfa1e2f852205a61a7cd1d5d93e92-6hfw9uyzy.vercel.app

@github-actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: a181042

✅ Preview: https://iota-rebased-explorer-092603f1de8088243ccb8b861b23e-g8c68ym4t.vercel.app

@alexsporn alexsporn added the vm-language Issues related to the VM & Language Team label Oct 25, 2024
@miker83z miker83z self-assigned this Oct 25, 2024
@miker83z miker83z linked an issue Oct 25, 2024 that may be closed by this pull request
@alexsporn alexsporn mentioned this pull request Oct 25, 2024
20 tasks
@Thoralf-M
Copy link
Member

Thoralf-M commented Oct 25, 2024

Looks like the iota-light-client tests are broken now because the TransactionEffects enum has only one variant now

--- TRY 2 STDERR:        iota-light-client::check_proof test_object_target_fail_wrong_object ---
thread 'test_object_target_fail_wrong_object' panicked at crates/iota-light-client/tests/check_proof.rs:34:63:
called `Result::unwrap()` on an `Err` value: Unable to parse checkpoint file: invalid value: integer `1`, expected variant index 0 <= i < 1

Ah I see #3665 is for this

@Dkwcs
Copy link
Contributor

Dkwcs commented Oct 25, 2024

We have to keep in mind effects.ts contains V2

Base automatically changed from core-node/feat/rename-execution-results to core-node/feat/remove-multiple-types-2 October 25, 2024 12:59
@miker83z miker83z merged commit a9e2cf7 into core-node/feat/remove-multiple-types-2 Oct 25, 2024
28 of 37 checks passed
@miker83z miker83z deleted the core-node/feat/rename-transaction-effects branch October 25, 2024 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

vm-language Issues related to the VM & Language Team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove multiple versions of TransactionEffectsV1

6 participants