-
Notifications
You must be signed in to change notification settings - Fork 58
refactor(iota-types/iota-system-state): Remove multiple versions from the iota-system-state types #3168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(iota-types/iota-system-state): Remove multiple versions from the iota-system-state types #3168
Conversation
crates/iota-types/src/iota_system_state/iota_system_state_inner_v1.rs
Outdated
Show resolved
Hide resolved
|
Please don't forget run |
5edc59b to
aeb0d0e
Compare
3b0f4fd to
b98d4cd
Compare
aeb0d0e to
c376496
Compare
6fb25d5 to
2a63305
Compare
crates/iota-types/src/iota_system_state/iota_system_state_inner_v1.rs
Outdated
Show resolved
Hide resolved
2babbd5 to
6ccee71
Compare
miker83z
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this PR could cover renaming StakedIota and TimelockedStakedIota as well! I think these are the only one remaining from the list in #3048 description
…TimelockedStakedIota
10cebb6 to
d660f40
Compare
275ffcd to
0ed0c63
Compare
|
I suggest these changes because I found it difficult to find a nice way to treat traits for Originally I was going with the approach of having Plus, the PR fixes the BCS conversions and makes the node run. |
…pes-fix fix(framework, types): rust old types
|
|
c29dd1f
into
core-node/feat/remove-multiple-types
Description of change
This PR will be merged to the feature branch
core-node/feat/remove-multiple-types.Note:
IotaSystemStateWrapperstill exists and corresponds toIotaSystemStatein Move. It's a thin wrapper for accessing the inner object and is rarely used in Rust. It's used only in genesis snapshots and testing, and in most cases, we use the enumIotaSystemStateinstead.PoolTokenExchangeRateto wraps different versions ofPoolTokenExchangeRateChanges to move codes:
This is supposed to be done in #3048 , but we forgot it.
ValidatorWrapperin Move toValidatorLinks to any relevant issues
Close #3154
Type of change
Choose a type of change, and delete any options that are not relevant.
How the change has been tested
cargo test:Change checklist
Tick the boxes that are relevant to your changes, and delete any items that are not.