Fix failing core-node tests after rebase

[muXxer]

Test failures

• iota-bridge crypto::tests::test_bridge_sig_verification_regression_test
• iota-bridge e2e_tests::basic::test_add_new_coins_on_iota_and_eth
• iota-bridge e2e_tests::basic::test_bridge_from_eth_to_iota_to_eth
• iota-bridge e2e_tests::complex::test_iota_bridge_paused
• iota-bridge encoding::tests::test_bridge_message_encoding
• iota-bridge encoding::tests::test_bridge_message_encoding_asset_price_update_action
• iota-bridge encoding::tests::test_bridge_message_encoding_blocklist_update_v1
• iota-bridge encoding::tests::test_bridge_message_encoding_emergency_action
• iota-bridge encoding::tests::test_bridge_message_encoding_evm_contract_upgrade_action
• iota-bridge encoding::tests::test_bridge_message_encoding_limit_update_action
• iota-bridge encoding::tests::test_bridge_message_encoding_regression_add_coins_on_evm
• iota-bridge encoding::tests::test_bridge_message_encoding_regression_add_coins_on_iota
• iota-bridge encoding::tests::test_bridge_message_encoding_regression_emitted_iota_to_eth_token_bridge_v1
• iota-bridge encoding::tests::test_bridge_message_encoding_regression_eth_to_iota_token_bridge_v1
• iota-bridge events::tests::test_bridge_events_when_init
• iota-bridge iota_client::tests::test_get_action_onchain_status_for_iota_to_eth_transfer
• iota-bridge iota_transaction_builder::tests::test_build_iota_transaction_for_committee_blocklist
• iota-bridge iota_transaction_builder::tests::test_build_iota_transaction_for_emergency_op
• iota-bridge iota_transaction_builder::tests::test_build_iota_transaction_for_limit_update
• iota-bridge iota_transaction_builder::tests::test_build_iota_transaction_for_price_update
• iota-bridge iota_transaction_builder::tests::test_build_iota_transaction_for_token_transfer
• iota-bridge node::tests::test_starting_bridge_node
• iota-bridge node::tests::test_starting_bridge_node_with_client
• iota-bridge node::tests::test_starting_bridge_node_with_client_and_separate_client_key
• iota-e2e-tests::bridge_tests test_bridge_api_compatibility
• iota-e2e-tests::bridge_tests test_committee_registration
• iota-metric-checker tests::test_parse_config
• iota-metrics tests::registry_service
• authority_tests::test_invalid_authenticator_state_parameter
• transaction_tests::test_zklogin_transfer_with_bad_ephemeral_sig
• transaction_tests::test_zklogin_caching_scenarios
• consensus-core network::connection_monitor::tests::test_connectivity
• iota-core authority::authority_tests::test_dev_inspect_dynamic_field
• iota-core authority::authority_tests::test_dev_inspect_gas_coin_argument
• iota-core authority::authority_tests::test_dev_inspect_gas_price
• iota-core authority::authority_tests::test_dev_inspect_object_by_bytes
• iota-core authority::authority_tests::test_dev_inspect_return_values
• iota-core authority::authority_tests::test_dev_inspect_unowned_object
• iota-core authority::authority_tests::test_dev_inspect_uses_unbound_object
• iota-core authority::authority_tests::test_dry_run_dev_inspect_dynamic_field_too_new
• iota-core authority::authority_tests::test_dry_run_dev_inspect_max_gas_version
• iota-core authority::authority_tests::test_dry_run_no_gas_big_transfer
• iota-core authority::authority_tests::test_dry_run_transaction_block
• iota-core authority::authority_tests::test_for_inc_201_dev_inspect
• iota-core authority::authority_tests::test_for_inc_201_dry_run
• iota-core move_package_upgrade_tests::test_conflicting_versions_across_calls
• iota-core move_package_upgrade_tests::test_different_versions_across_calls
• iota-core move_package_upgrade_tests::test_interleaved_upgrades
• iota-core move_package_upgrade_tests::test_multiple_upgrades_valid
• iota-core move_package_upgrade_tests::test_publish_override_happy_path
• iota-core move_package_upgrade_tests::test_publish_transitive_override_happy_path
• iota-core move_package_upgrade_tests::test_upgrade_cross_module_refs
• iota-core move_package_upgrade_tests::test_upgrade_incompatible
• iota-core move_package_upgrade_tests::test_upgrade_introduces_type_then_uses_it
• iota-core move_package_upgrade_tests::test_upgrade_package_additive_dep_only_mode
• iota-core move_package_upgrade_tests::test_upgrade_package_additive_mode
• iota-core move_package_upgrade_tests::test_upgrade_package_compatibility_too_permissive
• iota-core move_package_upgrade_tests::test_upgrade_package_compatible_in_additive_mode
• iota-core move_package_upgrade_tests::test_upgrade_package_compatible_in_dep_only_mode
• iota-core move_package_upgrade_tests::test_upgrade_package_dep_only_mode
• iota-core move_package_upgrade_tests::test_upgrade_package_happy_path
• iota-core move_package_upgrade_tests::test_upgrade_package_incorrect_digest
• iota-core move_package_upgrade_tests::test_upgrade_package_invalid_additive_mode
• iota-core move_package_upgrade_tests::test_upgrade_package_invalid_compatibility
• iota-core move_package_upgrade_tests::test_upgrade_package_missing_type
• iota-core move_package_upgrade_tests::test_upgrade_package_missing_type_module_removal
• iota-core move_package_upgrade_tests::test_upgrade_ticket_doesnt_match
• iota-core move_package_upgrade_tests::test_upgraded_types_in_one_txn
• iota-core move_package_upgrade_tests::upgrade_missing_deps
• iota-light-client checkpoints
• iota-e2e-tests::reconfiguration_tests test_passive_reconfig
• iota-e2e-tests::sdk_stream_tests test_coins_stream
• iota-e2e-tests::shared_objects_tests call_shared_object_contract
• iota-e2e-tests::reconfiguration_tests test_reconfig_with_failing_validator
• iota-e2e-tests::reconfiguration_tests test_reconfig_with_committee_change_stress_determinism
• iota-e2e-tests::reconfiguration_tests test_reconfig_with_committee_change_basic
• iota-e2e-tests::traffic_control_tests test_traffic_sketch_no_blocks
• iota-e2e-tests::shared_objects_tests shared_object_deletion_multiple_times
• iota-e2e-tests::transaction_orchestrator_tests test_tx_across_epoch_boundaries
• iota-faucet faucet::simple_faucet::tests::test_faucet_no_loop_forever
• iota-json-rpc-tests::governance_api get_committee_info
• iota-json-rpc-tests::move_utils get_move_function_arg_types
• iota-e2e-tests::full_node_tests test_full_node_sync_flood_determinism
• iota-network discovery::tests::test_access_types
• iota-e2e-tests::full_node_migration_tests test_full_node_load_migration_data
• iota-surfer::smoke_tests smoke_test

Simtest only

• iota-core congestion_control_tests::test_congestion_control_execution_cancellation
• iota-core quorum_driver::tests::test_quorum_driver_handling_overload_and_retry
• iota-e2e-tests::bridge_tests test_create_bridge_state_object
• iota-e2e-tests::checkpoint_tests test_checkpoint_split_brain
• iota-e2e-tests::multisig_tests test_max_epoch_too_large_fail_zklogin_in_multisig
• iota-e2e-tests::multisig_tests test_upgraded_multisig_feature_deny
• iota-e2e-tests::passkey_e2e_tests test_passkey_feature_deny
• iota-e2e-tests::randomness_tests test_create_randomness_state_object
• iota-e2e-tests::reconfiguration_tests test_reconfig_with_committee_change_stress
• iota-e2e-tests::reconfiguration_tests test_reconfig_with_committee_change_stress_determinism
• iota-e2e-tests::rest execute_transaction_transfer
• iota-e2e-tests::traffic_control_tests test_fullnode_traffic_control_ok
• iota-e2e-tests::traffic_control_tests test_traffic_sketch_no_blocks
• iota-e2e-tests::traffic_control_tests test_traffic_sketch_with_sampled_spam
• iota-e2e-tests::transfer_to_object_tests receive_object_feature_deny
• iota-e2e-tests::validator_tx_finalizer_e2e_tests test_validator_tx_finalizer_consensus_tx
• iota-e2e-tests::validator_tx_finalizer_e2e_tests test_validator_tx_finalizer_fastpath_tx
• iota-e2e-tests::zklogin_tests test_max_epoch_too_large_fail_tx
• iota-e2e-tests::apy_test::test_apy [skipped now, will be fix in Revisit APY calculation #3552 ]
• iota-json-rpc-tests::coin_api::get_all_balances
• iota-benchmark::simtest test::test_upgrade_compatibility
• iota-json-rpc-tests::move_utils get_normalized_move_module
• iota-json-rpc-tests::move_utils get_normalized_move_modules_by_package
• iota::cli_tests test_faucet
• 🚧 (Piotr) narwhal-network::connectivity::tests::test_connectivity
• iota-e2e-tests::protocol_version_tests sim_only_tests::iota_system_mock_smoke_test
• iota-e2e-tests::protocol_version_tests sim_only_tests::iota_system_state_deep_upgrade_test
• iota-e2e-tests::protocol_version_tests sim_only_tests::iota_system_state_shallow_upgrade_test
• iota-e2e-tests::protocol_version_tests sim_only_tests::test_safe_mode_recovery
• 🚧 (Piotr/Bing) iota-storage::key_value_tests simtests::test_multi_fetch
• 🚧 (Daria) iota-e2e-tests::full_node_tests test_full_node_event_read_api_ok
• 🚧 (Daria) iota-e2e-tests::full_node_tests test_full_node_indexes
• 🚧 (Hans) iota-e2e-tests::reconfiguration_tests safe_mode_reconfig_test
• 🚧 (Piotr/Bing) iota-e2e-tests::reconfiguration_tests test_epoch_flag_upgrade

Flaky Simtests

• iota-core::format::test_format
• iota-e2e-tests::shared_objects_tests::shared_object_deletion_multiple_times
• iota-json-rpc-tests::balance_changes_tests::test_dry_run_publish_with_mocked_coin
• iota-json-rpc-tests::governance_api::get_committee_info
• iota-open-rpc::generate-spec::test_json_rpc_spec
• 🚧 (Mirko) iota-rosetta::end_to_end_tests::test_withdraw_stake

[miker83z]

I found also these ones failing in the iota-core:

• authority_tests::test_invalid_authenticator_state_parameter
• transaction_tests::test_zklogin_transfer_with_bad_ephemeral_sig
• transaction_tests::zklogin_test_caching_scenarios

[alexsporn]

This one needs fixing/skipping due to us disabling zklogin and the jwk updating

  TRY 1 FAIL [  13.846s] iota-core authority::authority_tests::test_invalid_authenticator_state_parameter

--- TRY 1 STDOUT:        iota-core authority::authority_tests::test_invalid_authenticator_state_parameter ---

running 1 test
test authority::authority_tests::test_invalid_authenticator_state_parameter ... FAILED

failures:

failures:
    authority::authority_tests::test_invalid_authenticator_state_parameter

test result: FAILED. 0 passed; 1 failed; 0 ignored; 0 measured; 449 filtered out; finished in 13.77s


--- TRY 1 STDERR:        iota-core authority::authority_tests::test_invalid_authenticator_state_parameter ---
thread 'authority::authority_tests::test_invalid_authenticator_state_parameter' panicked at crates/iota-core/src/unit_tests/authority_tests.rs:3078:5:
assertion `left == right` failed
  left: ObjectNotFound { object_id: 0x0000000000000000000000000000000000000000000000000000000000000007, version: None }
 right: InaccessibleSystemObject { object_id: 0x0000000000000000000000000000000000000000000000000000000000000007 }

[bingyanglin]

Note that the following Flaky tests

• iota-e2e-tests::shared_objects_tests::shared_object_deletion_multiple_times (simtest)
• iota-json-rpc-tests::balance_changes_tests::test_dry_run_publish_with_mocked_coin
• iota-json-rpc-tests::governance_api::get_committee_info (simtest)

are hard to reproduce locally, passed after the cargo sim rust flag fixing at #3514, and recent tests:

• https://github.com/iotaledger/iota/pull/3514/checks (merged at commit 9e337)
• https://github.com/iotaledger/iota/pull/3633/checks (merged at commit 6f14c)
• https://github.com/iotaledger/iota/pull/3602/checks (merged at commit 4db2c)

so I marked them as resolved. Need to investigate them again if see them flaky in the future tests.